Repository navigation
Conversation
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
benjelloun
approved these changes
Oct 28, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1060.
Problem
execute_operations_in_beamshards on theFilterFilesoperation, so every operation after it runs once per file. For aFileSetthat iscontainedInan archive, the first of those isConcatenate, and it receives a singlePathinstead of alist[Path]:This breaks
mlc.ReadFromCroissantandtfds.dataset_builders.CroissantBuilderfor every dataset whoseFileSetis extracted from a zip or tar.Dataset.records()is not affected.Fix
Concatenate.callnow accepts either aPathor alist[Path], the same wayRead.callalready does.Tests
concatenate_test.py: new unit test covering a list of paths (sequential execution), single paths (Beam execution), and a mix of both.datasets_test.py: addedrecipes/read_binary_file_by_line.json/translations_from_ziptotest_beam_hermetic_loading. The existing Beam cases (simple-parquet,simple-join) have noFileSet, soConcatenatenever ran under Beamin CI. Without the fix, the new case fails with theTypeErrorabove for both 1.0 and 1.1.Note: the issue suggested
read_from_tar.json/images_with_annotations. That record set joins two FileSets, so underBeam it fails earlier with the existingNotImplementedError: Found several FilterFiles - not handled yet.and never reachesConcatenate.translations_from_ziphas a single FileSet inside a zip, so it exercises this exact path.The reproduction script from #1060 now prints the expected 3 records with their global indices.