Conversation
set_tool_version() previously crammed the Git tag/hash into the generationTool string (e.g. generationTool="Reference FMUs (2.0.4)"), even though fmiModelDescription has a dedicated version attribute for this purpose. Now generationTool stays a plain tool name and the tag/ hash is written to a separate version attribute alongside generationDateAndTime. Also moved the set_tool_version() call so it runs for every merged FMU instead of only the ones with simulation/plot parameters (previously Clocks and Roberts were skipped and always kept the development-build placeholder).
Tc-Fast
force-pushed
the
fix-fmu-version-attribute
branch
from
September 21, 2026 06:43
076aa4e to
a458e2e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #269
set_tool_version() previously crammed the Git tag/hash into the generationTool string (e.g. generationTool="Reference FMUs (0.0.41)"), even though fmiModelDescription has a dedicated version attribute for this purpose. Now generationTool stays a plain tool name and the tag/ hash is written to a separate version attribute alongside generationDateAndTime.
Also moved the set_tool_version() call so it runs for every merged FMU instead of only the ones with simulation/plot parameters (previously Clocks and Roberts were skipped and always kept the development-build placeholder).
@t-sommer
Please review.