Adding get_fmu_kind function - #420
Merged
Merged
Conversation
efredriksson-modelon
requested changes
Sep 8, 2026
PeterMeisrimelModelon
force-pushed
the
dev-pm-551
branch
2 times, most recently
from
September 8, 2026 08:36
ed58f39 to
4ed1837
Compare
PeterMeisrimelModelon
force-pushed
the
dev-pm-551
branch
from
September 8, 2026 08:38
4ed1837 to
fed8407
Compare
Add the string enum `FMUKind` and `get_fmu_kind()`, so the kind of an FMU instance can be queried directly instead of via `isinstance(fmu, (FMUModelCS1, FMUModelCS2, FMUModelCS3))`.
Replace the ME-vs-CS `isinstance(self, ...)` checks in `FMUModelBase2` with `get_fmu_kind()`, and fold the private FMI3 `_get_fmu_kind()` into the new public function, so the kind is determined in one place per class.
PeterMeisrimelModelon
force-pushed
the
dev-pm-551
branch
from
September 8, 2026 08:41
fed8407 to
13f94e8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.