fix(mgr-api): whitelist filter_* на списках customers - #457
Open
Ibochkarev wants to merge 2 commits into
Open
Conversation
Reject filter queries on secret msCustomer columns (token, password) and route UI filter keys through ManagerListFilterPolicy. Apply the same guard to deliveries and payments list endpoints.
Move OrdersController applyFilter whitelist into shared policy with explicit ORDER_FILTER_MAP and blocklist. Align filter param guards with other grids.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Описание
CustomersController::getListпринимал любыеfilter_*и строилLIKEпо произвольной колонке.filter_token=<prefix>давал oracle по секретному полю, хотяtokenне попадает в ответ списка.Добавлен
ManagerListFilterPolicy: whitelist полей UI-фильтров + blocklist секретных колонок. Тот же guard применён к спискам deliveries/payments (как в #420).Тип изменений
Связанные Issues
Closes #420
Как это было протестировано?
composer ci:php)Конфигурация тестирования:
fix/issue-420-customer-filter-whitelistСкриншоты (если применимо)
n/a
Чеклист
Дополнительные заметки
Whitelist customers:
customer_name,email,phone,is_active(+ aliasactive).Blocklist (все grids):
token,password,properties,class,validation_rules.Бонус:
customer_nameтеперь ищет поfirst_name/last_name(раньше LIKE шёл по несуществующей колонке).Follow-up: унификация whitelist в
OrdersController::applyFilter— отдельная задача.