Repository navigation
Conversation
The design guide said the setup allowlist does not copy REA_MCP_MAX_RESPONSE_BYTES, but SELECTED_REGISTRATION_SETTINGS includes it and setup forwards an explicit selection, as the client guide states. Fixes morluto#7420
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
[Low impact] This documentation correction appears safe to merge. SummaryCorrects
Reviews (1) · Last reviewed commit: "docs(limits): say setup forwards the sel..." · Reviewed by Greptile |
98 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #7420.
docs/design/limits-and-recovery.mdsaid the setup allowlist does not copyREA_MCP_MAX_RESPONSE_BYTES. That is wrong: the setting is inSELECTED_REGISTRATION_SETTINGS, setup forwards an explicit selection into the client registration, anddocs/client-configuration.mdalready says so. The paragraph now states the actual behavior.Problem and expected behavior
Change and scope
docs/design/limits-and-recovery.md: replace "The setup allowlist does not copy this setting. A new headroom setting should, following the regex deadline." with a statement that, like the regex deadline, the setting is inSELECTED_REGISTRATION_SETTINGSand setup forwards an explicit selection.Follow the contribution scope.
Unresolved scope, authority, side effects, or required verification block
integration. Link the required maintainer scope decision for new providers or
capabilities involving target execution, injection, mutation, or protection
recovery; ordinary fixes within existing boundaries may state "not applicable".
Draft PRs may leave the scope decision pending and the readiness and merge checklists
unchecked. Maintainers can help resolve open questions.
Contract and boundary impact
SELECTED_REGISTRATION_SETTINGSinsrc/application/SetupRegistrationEnvironment.ts(unchanged); only the design guide that describes it changes.docs/public/product-catalog.json), package, or installation impact (CI generates and validates ignored catalogs andskills/; edit authored instructions in.agents/skills/reverse-engineer-anything/and never commit build outputs): none.Expected effects (check known effects; use documentation-only on its own).
Unchecked items do not establish absence; leave uncertainties visible.
Evidence and regression coverage
Tests added or updated: none (documentation only).
Base reproduction or other evidence (executed): built CLI at
8282bc3c7(this branch; the setup code is unchanged frommain60149282f), isolatedHOME, no files written:The planned
configure_client:codexaction reportsDetected provider environment: REA_MCP_MAX_RESPONSE_BYTES=20971520.Without the variable, the plan does not mention it.Source:
SELECTED_REGISTRATION_SETTINGSlists"REA_MCP_MAX_RESPONSE_BYTES", andexplicitSetupRegistrationEnvironmentcopies every listed key that the caller set.User-visible CLI/MCP output (if applicable): none changed.
Remaining proof gaps: a non-dry-run setup that writes a client registration was not run.
For evidence-bearing changes:
Validation performed
At
8282bc3c7(based onmain60149282f; macOS 26.5.2, Node 24.22.1):npm run docs:check— passednpm run format:check— passednpm run test:local -- src/mcpStartupPolicy.test.ts— 6 passed (includes the explicit 20971520-byte response budget selection)Compatibility, safety, and release
Author readiness
Human owner: @chordpli
Before merge
type(scope): outcome.