chore!: drop EOL node 20, require node >= 22 - #4
Merged
Conversation
Node 20 reached end-of-life on 2026-04-30, so the matrix keeps only the still-supported LTS lines: 22 (maintenance, EOL 2027-04-30) and 24 (active, EOL 2028-04-30). Dropping it also removes the reason the standalone-pnpm workaround existed. pnpm 11 requires node >= 22.13, which every remaining matrix entry satisfies, so the hand-rolled GitHub-release download is replaced by pnpm/action-setup@v6 — which reads the version from packageManager and still runs before setup-node so `cache: 'pnpm'` resolves. Bump checkout and setup-node to v7.
Align the declared support surface with what CI actually verifies: engines, the tsup compile target, and the requirements section of both READMEs all said node 20, which is EOL as of 2026-04-30. @types/node deliberately stays on ^24 to match the development and runtime environment; the node 22 CI job is what guards the floor. BREAKING CHANGE: node 20 is no longer supported. Install now requires node >= 22.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node 20 reached end-of-life on 2026-04-30 (
nodejs/Releaseschedule.json), so this drops it everywhere and realigns the declared support surface with what CI actually verifies.CI
[20, 22, 24]→[22, 24]— the two still-supported LTS lines (22 maintenance until 2027-04-30, 24 active until 2028-04-30).pnpm/action-setupstandalone mode and@pnpm/exewere both broken for 11.13.0 — see Error after installing in standalone mode when trying to install packages with a CLI globally -This: not foundpnpm/action-setup#277). Every remaining matrix entry satisfies that floor, sopnpm/action-setup@v6handles it. It still runs beforesetup-nodesocache: 'pnpm'resolves, and picks up the version frompackageManager.actions/checkoutandactions/setup-node→ v7.Side benefit: the deleted step was the workflow's only hand-rolled
run:block doing a network fetch — less surface to audit.Support surface
engines.node>=20>=22targetnode20node22@types/nodeintentionally stays on^24to match the dev and runtime environment. The node 22 CI job — which runs the full suite, not just typecheck — is what guards the floor.Verification
Run locally on node 24.18.0 / pnpm 11.13.0:
pnpm lintpnpm typecheckpnpm testpnpm buildTarget: node22node dist/bin/motrix.js --version0.4.0pnpm-lock.yamlis unchanged.Follow-up (not in this PR)
Node 26 becomes Active LTS on 2026-10-20. Worth adding to the matrix before then for early warning.