fix: escape double quotes in POSIX paths - #526
Open
saitakarcesme wants to merge 1 commit into
Open
saitakarcesme wants to merge 1 commit into
saitakarcesme wants to merge 1 commit into
Conversation
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
Author
|
A quick follow-up: the CI, Benchmark and CodeQL workflow runs are still marked action_required. Could a maintainer approve the fork workflow runs when convenient so this change can be validated? Follow-up prepared with Codex assistance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Make
posix.escapePathandposix.convertPathToPatternusable for directories containing double quotes. For example,posix.escapePath('"path') + '/*.txt'currently returns no files from"path, because the quote is left unescaped and interpreted by the glob parser.Related to #494. This provides a fix through the path-escaping APIs; it does not change the interpretation of raw glob patterns.
What changes did you make? (Give an overview)
Validation: five regressions failed before the fix.
npm run buildpasses (TypeScript, ESLint, 281 unit tests);npm run test:e2epasses with 1,386 tests and 9 platform-dependent pending tests on macOS / Node 22.22.2.AI-assisted implementation and testing.