Repository navigation
docs: accurate CONTRIBUTING (setup, real CI checks, no false 100% coverage claim) - #20
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CONTRIBUTING.mdwas a single line: "Strict adherence to pure functional programming and 100% test coverage is mandated." Neither claim is true or enforced.Measured coverage on master is 92% (
pytest --cov=edge_mining_framework). CI has no coverage threshold.The new guide:
Every command in the new file was run on this branch and passes. One exception: plain
uv run pyteststill fails collection on master until #19 lands, because the Core conformance test imports verdict-core. After #19 it passes.