Repository navigation
Reject SEPA purpose codes that sit between Z and a - #6
Merged
Merged
Conversation
The purpose pattern used A-z, so a bracket was accepted and written into the QR payload. Letters and digits still pass.
Contributor
Author
|
Thanks for merging this. |
SashaMIT
added a commit
to SashaMIT/oss-contributions
that referenced
this pull request
Sep 26, 2026
A SEPA purpose code no longer accepts the characters between Z and a.
Owner
|
Thank you for your PR! Released v1.2.0. |
Contributor
Author
|
Thank you. Glad it made v1.2.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
purpose=accepted[because the pattern was[A-z0-9]. That range includes the six characters between Z and a. A purpose of[was written into the QR payload. The pattern is now letters and digits.GDDSstill passes.Test plan
bundle exec ruby -Itest test/girocode_test.rb -n test_purpose_rejects_gap_charactersfails on master because no error is raisedbundle exec ruby -Itest test/girocode_test.rbpasses on this branch (6 runs, 0 failures)