Skip to content

馃殮 Move DD sampling to MQT DDSIM - #529

Draft
simon1hofmann wants to merge 2 commits into
mainfrom
codex/2103-move-dd-sampling-to-ddsim
Draft

馃殮 Move DD sampling to MQT DDSIM#529
simon1hofmann wants to merge 2 commits into
mainfrom
codex/2103-move-dd-sampling-to-ddsim

Conversation

@simon1hofmann

@simon1hofmann simon1hofmann commented Aug 27, 2026

Copy link
Copy Markdown

馃 AI text below 馃

Description

Move the DD sampling used by the CSP and TSP solvers from mqt.core.dd to
mqt.ddsim, where the high-level simulator API is moving as part of
munich-quantum-toolkit/core#2103.

ProblemSolver now requires Python 3.11 after #528, so this branch imports
sample from DDSIM unconditionally and adds mqt.ddsim>=2.6.0. No
ProblemSolver API or solver behavior is intended to change.

Dependencies and merge order

This draft depends on munich-quantum-toolkit/core#2273,
munich-quantum-toolkit/ddsim#978, and the publication of MQT DDSIM 2.6.0. Once
that release is available, regenerate and commit uv.lock, run the full
lint/test checks, and mark this pull request ready for review.

Validation

  • source formatting, Ruff, and Markdown checks pass
  • the uv-lock and ty checks cannot resolve the unreleased DDSIM 2.6.0
    dependency yet

AI assistance

Codex materially assisted with implementation, validation, review, and this pull
request description. A human must review and understand the changes before
marking this pull request ready.

Checklist

  • The pull request only contains commits that are focused and relevant to this change.
  • Existing CSP and TSP tests cover the migrated sampling paths.
  • No documentation update is required because the ProblemSolver API and behavior are unchanged.
  • The changes follow the project's style guidelines and introduce no new warnings. Source checks pass; dependency-resolution checks await DDSIM 2.6.0.
  • The changes are fully tested and pass the CI checks.
  • I have reviewed my own code changes.

If PR contains AI-assisted content:

  • Any agent that created, edited, or submitted GitHub content was explicitly authorized for that scope, as required by our AI Usage Guidelines.
  • Every agent-authored or agent-edited public text body begins with the visible disclosure 馃 *AI text below* 馃 (titles are exempt).
  • I have disclosed AI assistance in the PR description.
  • I confirm that I have personally reviewed and understood all AI-generated content, and accept full responsibility for it.

@simon1hofmann simon1hofmann added dependencies Pull requests that update a dependency file python Pull requests that update python code labels Aug 27, 2026
@burgholzer

Copy link
Copy Markdown
Member

The 3.10 fallback can be dropped as we are dropping 3.10 support everywhere (including here).

@simon1hofmann
simon1hofmann force-pushed the codex/2103-move-dd-sampling-to-ddsim branch from 33551ff to 4aa2468 Compare August 28, 2026 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file python Pull requests that update python code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants