Conversation
|
The samples that would be used by this PR are section samples, not solo, right? As far as I know, we don't have solo tremolo samples. So a solo violin with tremolo would now use the section tremolo sound. We'll have to ask the design team what they prefer: solo+tremolo just using the solo sound without tremolo (current situation) or solo+tremolo using the section+tremolo sound (this PR). |
|
FWIW, MU3 and earlier did it this way - section tremolo sounds for solo instrument - and we rarely if ever got complaints. To me it's very clearly preferable. |
|
@cbjeukendrup thanks for bringing up this design consideration! You're right that the samples would be section samples, not solo. Using Bank 0, Program 44 (generic tremolo) for individual is perhaps more academic and also would have these advantages:
@MarcSabatella Thanks for the historical context about MU3 behavior In any way I can adapt my SF2 files for plectro Spanish orchestras to be able to reproduce tremolo correctly. Would you like me to update the PR to use Bank 0 for individual instruments instead? |
0c140c6 to
916fc8a
Compare
|
After investigating the playback code further, the I've rolled back changes regardin the |
916fc8a to
fcb1a7a
Compare
|
Closed in favour of musescore/muse_framework#263, which targets the project this code was migrated to. |
|
Maybe you could reopen and rebase to 4.7 (which doesn't use muse_framework)? |
Only the *_SECTION variants had tremolo entries, so violin, viola, violoncello and contrabass fell back to the default arco sound with SF2 soundfonts. Fixes: musescore#21122
fcb1a7a to
65bfdab
Compare
|
@Jojo-Schmitz reopened, rebased and retargeted to 4.7 |
Summary
Now string instruments correctly select tremolo MIDI presets when using SF2 soundfonts.
soundmapping.h*_SECTIONvariants had tremolo mappings, so individual instruments fell back to the default arco soundAffected mappings
midi::Program(20, 44)midi::Program(30, 44)midi::Program(40, 44)midi::Program(50, 44)Resolves: #21122