Fix missing includes - #275
Conversation
extensionsession.h uses 'const Manifest&' as a parameter type but only includes iextensionsession.h and scriptengine.h, neither of which provides the Manifest definition (declared in extensionstypes.h). This compiles only when extensionstypes.h is transitively included through other headers, which varies between Qt distributions. Closes musescore#272 Assisted-by: OpenRouter:z-ai/glm-5.2 opencode
extapiv1.cpp and uimodule.cpp call qmlRegisterType() and qmlRegisterSingletonType() without including <QQmlEngine>, which declares these functions in Qt 6. The calls compile only when <QQmlEngine> is transitively included through other headers, which varies between Qt distributions. Closes musescore#273 Assisted-by: OpenRouter:z-ai/glm-5.2 opencode
…getBase.cpp DockWidgetBase.cpp calls methods on QAction objects (e.g. setEnabled(), triggered signal) but does not include <QAction>. The code compiles only when <QAction> is transitively included through other QtGui headers, which varies between Qt distributions. This is already fixed in upstream KDDockWidgets 2.x, but the vendored snapshot is 1.4.95. Closes musescore#274 Assisted-by: OpenRouter:z-ai/glm-5.2 opencode
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (4)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughAdded missing header includes to framework source files. The changes add Merge Risk: ⚪ Minimal · up to This change restores explicit Qt and extension-type header dependencies so the framework no longer relies on transitive includes, without changing runtime behavior. No current merge-readiness risk remains. 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
Full details: Linked Issues checkExplanation The changes address parts of issues [ Resolution Add all remaining include directives required by issues [
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Most of the include fixes were already addressed by #256, which is newer than the vendored version in Audacity 4 at the time of opening this PR. So the CodeRabbit feedback is not applicable. |
Resolves: #272
Resolves: #273
Resolves: #274
Full context in the issue reports and commit messages.
Build configuration
audacity: audacity/audacity/master
audacity platforms: linux_x64
musescore: musescore/MuseScore/main
musescore platforms: linux_x64