Show legacy plugin errors to users - #280
Conversation
|
Warning Review limit reachedNext included review available in 48 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (2)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthrough
Priority: ➖ Normal Severity of issue fixed: Medium Merge Risk: ⚪ Minimal · up to Legacy QML plug-in load and creation failures now present copyable, wrapped error details to users while retaining the existing failure results. No concrete current-head merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 25.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 2 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ca7b5fa to
ca2987c
Compare
Resolves: musescore/MuseScore#28545
This is the
muse_frameworkportion of the MuseScore plug-in error-reporting change. It displays errors encountered while loading or creating legacy QML plug-ins, provides the technical message as copyable details, and allows long details text to wrap in the shared error-details view.Companion MuseScore PR: musescore/MuseScore#34864
Validation:
git diff --checkUncrustify validation of
extpluginrunner.cppandextpluginrunner.hBuilt and launched MuseScore Studio Development
Tested with several deliberate QML plug-in errors
I signed the CLA as michaelnorris.
The title of the PR describes the problem it addresses.
Each commit's message describes its purpose and effects, and references the issue it resolves.
The code in the PR follows the coding rules.
I understand all aspects of the code I'm contributing and I'm able to explain it if requested.
The code compiles and runs on my machine. I have manually tested and verified that my changes fulfil their intended purpose.
No prior attempts to resolve this problem exist, or if they do, they are described above.
There are no unnecessary changes.
I created a unit test or vtest to verify the changes I made (if applicable).
Build configuration
audacity: audacity/audacity/master
audacity platforms: linux_x64
musescore: mnorrisvuw/MuseScore/codex/fix-28545-plugin-error-dialog
musescore platforms: linux_x64