New crash handler functionalities - #285
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe change adds the Merge Risk: ⚪ Minimal · up to The change exposes crash-handler controls for session tagging and macOS crash-dialog suppression while keeping the exported handler aligned with diagnostics startup. No actionable merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
13633ef to
611ac9e
Compare
611ac9e to
bdc6a5c
Compare
Needed for audacity/audacity#11427
It promotes CrashHandler to an exportable ICrashHandler, with two interfaces:
addSessionTag, so that our plugin-registration processes can be filtered on Sentry,setSystemCrashReporterForwardingEnabled, to allow a process on macos to stop the " quit unexpectedly" dialog, which annoy everyone during plugin registration on macos who has crashing plugins during#Documentation on minidump annotations for Sentry: https://docs.sentry.io/platforms/native/guides/minidumps/
addresses.
Build configuration
audacity: audacity/audacity/master
audacity platforms: linux_x64
musescore: musescore/MuseScore/main
musescore platforms: linux_x64