Skip to content

Add eraser icon code - #338

Merged
ajuncosa merged 1 commit into
musescore:mainfrom
ajuncosa:icon-code
Oct 6, 2026
Merged

ajuncosa merged 1 commit into
musescore:mainfrom
ajuncosa:icon-code

Conversation

@ajuncosa

@ajuncosa ajuncosa commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

@ajuncosa
ajuncosa requested a review from mathesoncalum October 6, 2026 10:35
@coderabbitai

coderabbitai Bot commented Oct 6, 2026

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: musescore/muse_framework/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 1ff0a9f9-65bf-4efa-9935-0f68d41af3b1
📥 Commits

Reviewing files that changed from the base of the PR and between f8961d5 and 35175b6.

📒 Files selected for processing (1)
  • framework/ui/view/iconcodes.h

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

Adds ERASER with value 0xF3CC to IconCode::Code.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 35175

The new eraser icon code maps to an eraser-shaped glyph and is ready to merge after normal checks.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description links to the related MuseScore issue and states why the change is needed, but it omits the required checklist and a clear summary of the change. Add a short description of the change and its motivation. Identify issue #34508 with the template's “Resolves” field or a direct link. Complete each required checklist item, and complete the applicable AI-assistance and test items.
Docstring Coverage ⚠️ Warning Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: adding an eraser icon code.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ajuncosa
ajuncosa merged commit e15f864 into musescore:main Oct 6, 2026
3 checks passed
@ajuncosa
ajuncosa deleted the icon-code branch October 6, 2026 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants