Skip to content

Fix startup crash when reloading extensions from a global-context provider #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
luapmartin wants to merge 1 commit into from
Closed

Fix startup crash when reloading extensions from a global-context provider #342

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion framework/extensions/internal/extensionsprovider.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,12 @@ void ExtensionsProvider::reloadExtensions()
//! NOTE Without this, reloading picks up a plugin's manifest but keeps
//! running the code the engine compiled the first time, so edits to a
//! plugin only take effect after a restart.
extensionsUiEngine()->clearComponentCache();
//! A provider created with the global context (e.g. to scan manifests before
//! any window exists) has no UI engine, so there is nothing to clear.
const modularity::ContextPtr& ctx = iocContext();
if (ctx && ctx->id > 0) {
extensionsUiEngine()->clearComponentCache();
}

@igorkorsukov igorkorsukov Oct 7, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this way is better, it's clearer

if (extensionsUiEngine) {
     extensionsUiEngine()->clearComponentCache();
}

@luapmartin luapmartin Oct 7, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's no bool operator on InjectBase and if we want to use the call form then we gonna hit the asserts on ctx->id > 0

@igorkorsukov igorkorsukov Oct 7, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes, you're right.

@igorkorsukov igorkorsukov Oct 7, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But something isn't right here :)
ExtensionsProvider itself is also contextual.
How does it happen that it gets created, yet extensionsUiEngine doesn't?


extensionsRegister()->reload();
}
Expand Down