Add makeItems helper to AbstractMenuModel

[ajuncosa]

Needed by: musescore/MuseScore#35164

This facilitates the reuse of command lists between different menus that must be kept aligned (in this case, the measure insert commands from the context menu, Add > Measures menu and + > Measures menu).

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 53 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

• Configuration used: Repository: musescore/muse_framework/.coderabbit.yaml
• Review profile: ASSERTIVE
• Plan: Advanced
• Run ID: 032a8f5f-9f78-4032-916f-99456b41e2b8

📥 Commits

Reviewing files that changed from the base of the PR and between 5b6f3bc and 61cb57e.

📒 Files selected for processing (1)

• framework/uicomponents/qml/Muse/UiComponents/abstractmenumodel.h

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Repository: musescore/muse_framework/.coderabbit.yaml
• Review profile: ASSERTIVE
• Plan: Advanced
• Run ID: bdabdad8-74d9-49bf-b010-d696f7146b72

📥 Commits

Reviewing files that changed from the base of the PR and between 92394d8 and 5b6f3bc.

📒 Files selected for processing (2)

• framework/uicomponents/qml/Muse/UiComponents/abstractmenumodel.cpp
• framework/uicomponents/qml/Muse/UiComponents/abstractmenumodel.h

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

---

📝 Walkthrough

Walkthrough

The change adds MenuCommandList, a vector of optional commands, and MENU_SEPARATOR, an empty optional command. It adds AbstractMenuModel::makeItems, which creates a menu item for each command value and a separator for each empty entry.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 5b6f3

This change adds a protected menu-conversion helper. No concrete user-facing failure is established, so no actionable merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description explains the purpose and identifies the dependent MuseScore pull request, but it omits the required Resolves line and the repository checklist, including CLA, testing, coding rules, …	Add the required template sections. Include an issue number or link after Resolves:, complete each checklist item accurately, and fill in the applicable unit-test and AI-assistance details.
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 2 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the main change: adding the makeItems helper to AbstractMenuModel.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Full details: Description check

Explanation

The description explains the purpose and identifies the dependent MuseScore pull request, but it omits the required Resolves line and the repository checklist, including CLA, testing, coding rules, prior attempts, unnecessary changes, and applicable unit-test or AI-assistance items.

✨ Finishing Touches 💡 1

🛠️ Fix failing CI checks 💡

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Create a new PR

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}