added stubs to shortcut v2 and availability flag to commands

[igorkorsukov]

No description provided.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Repository: musescore/muse_framework/.coderabbit.yaml
• Review profile: ASSERTIVE
• Plan: Advanced
• Run ID: f12bcfa8-f93f-43a5-924e-0dd5460a518d

📥 Commits

Reviewing files that changed from the base of the PR and between 92394d8 and f2fb947.

📒 Files selected for processing (25)

• framework/audio/main/internal/audiocommandsregister.cpp
• framework/dockwindow/internal/dockcommandsregister.cpp
• framework/dockwindow_v2/internal/dockcommandsregister.cpp
• framework/extensions/internal/extensionscommandsregister.cpp
• framework/musesampler/internal/musesamplercommandsregister.cpp
• framework/shortcuts_v2/internal/shortcutscontroller.cpp
• framework/shortcuts_v2/qml/Muse/Shortcuts/platform/macos/macosshortcutsinstancemodel.mm
• framework/shortcuts_v2/shortcutstypes.h
• framework/stubs/CMakeLists.txt
• framework/stubs/shortcuts_v2/CMakeLists.txt
• framework/stubs/shortcuts_v2/qml/Muse/Shortcuts/CMakeLists.txt
• framework/stubs/shortcuts_v2/qml/Muse/Shortcuts/Shortcuts.qml
• framework/stubs/shortcuts_v2/shortcutsconfigurationstub.cpp
• framework/stubs/shortcuts_v2/shortcutsconfigurationstub.h
• framework/stubs/shortcuts_v2/shortcutscontrollerstub.cpp
• framework/stubs/shortcuts_v2/shortcutscontrollerstub.h
• framework/stubs/shortcuts_v2/shortcutsregisterstub.cpp
• framework/stubs/shortcuts_v2/shortcutsregisterstub.h
• framework/stubs/shortcuts_v2/shortcutsstubmodule.cpp
• framework/stubs/shortcuts_v2/shortcutsstubmodule.h
• framework/testflow/internal/testflowcommandsregister.cpp
• framework/ui/internal/navigationcommandsregister.cpp
• framework/update/internal/updatecommandsregister.cpp
• framework/vst/internal/vstcommandsregister.cpp
• framework/workspace/internal/workspacecommandsregister.cpp

💤 Files with no reviewable changes (1)

• framework/shortcuts_v2/qml/Muse/Shortcuts/platform/macos/macosshortcutsinstancemodel.mm

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

---

📝 Walkthrough

Walkthrough

Command registrations now specify Dispatch or All availability. Shortcut activation uses command identifiers for enabled-state checks and dispatch, and its logging includes the sequence and allowed shortcuts. macOS shortcut loading now uses only the command shortcut register. The change also adds shortcuts_v2 stub implementations and CMake configuration, including optional QML stub support.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to f2fb9

No merge-blocking issue was identified; the shortcut changes are consistent with the documented command behavior.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	No pull request description was provided. The required issue reference, change summary, checklist responses, AI-assistance disclosure if applicable, and build configuration details are missing.	Add a complete pull request description using the repository template. Include the issue reference, a summary and motivation, accurate checklist selections, AI-assistance details if applicable, and the required build configuration informati…
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 49 functions across 20 files. (4 skipped: …	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title identifies both main changes: adding Shortcuts v2 stubs and adding availability flags to commands. It is concise and related to the changeset, despite minor spacing and grammar issues.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Full details: Description check

Resolution

Add a complete pull request description using the repository template. Include the issue reference, a summary and motivation, accurate checklist selections, AI-assistance details if applicable, and the required build configuration information.

Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 49 functions across 20 files. (4 skipped: 4 unsupported.)

• Fix all pre-merge checks with AI

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}