Skip to content

System becomes a hub, with all log levels on Diagnostics - #3231

Merged
marcelveldt merged 1 commit into
mainfrom
t3/settings-system-hub
Nov 18, 2026
Merged

marcelveldt merged 1 commit into
mainfrom
t3/settings-system-hub

Conversation

@marcelveldt

@marcelveldt marcelveldt commented Nov 18, 2026 •

Copy link
Copy Markdown
Member

What does this implement/fix?

System was a list of technical modules, and the log level of each module sat on whichever page showed that module. System is now the place for running the server, like the System page in Home Assistant, and all log levels are set together on Diagnostics.

  • System shows rows to Network, Background tasks and Diagnostics; a module that no settings page shows yet (one added to the server later) gets a row of its own, so its settings stay reachable
  • Diagnostics gets a Log levels section with one row per module, and the cache settings (Clear cache)
  • No other settings page shows the log level of a module any more
  • Background tasks opens its Task settings on a page of its own
  • Self-registration shows on User management, once the server gives it its own category (Group the crossfade, volume normalization and self-registration settings by what they do server#7889); until then it stays on the Network page
  • The menu lists Players right after Music sources and Plugins after Audio analysis
  • The breadcrumbs follow: System › Background tasks › Task settings

Builds on #3229.

Tested live in a preview build together with the rest of the Settings restructure, so no screenshots.

Related issue (if applicable):

Related backend PR (if applicable):

Types of changes

  • Bugfix (non-breaking change which fixes an issue) — bugfix
  • New feature (non-breaking change which adds functionality) — new-feature
  • Enhancement to an existing feature — enhancement
  • Breaking change (fix or feature that would cause existing functionality to not work as expected) — breaking-change
  • Refactor (no behaviour change) — refactor
  • Maintenance / chore — maintenance
  • CI / workflow change — ci
  • Dependencies bump — dependencies

Checklist

  • The code change is tested and works locally.
  • pnpm lint:check passes.
  • pnpm test:run passes, and tests have been added/updated where applicable.
  • pnpm build passes.
  • I have read and complied with the project's AI Policy for any AI-assisted contributions.

@marcelveldt

Copy link
Copy Markdown
Member Author

@Bot-MArley review

@Bot-MArley Bot-MArley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

This comment was written by Claude and posted by Bot-MArley on behalf of the Music Assistant maintainers.

This turns System into a hub with rows to Network, Background tasks and Diagnostics, moves every module's log level to one Log levels section on Diagnostics, and gives Task settings their own page. The code looks solid: saving a log level sends only that key, and the server keeps the module's other values. Self-registration follows the entry's category, so it works before and after music-assistant/server#7889.

Requested changes

  1. [PROBLEM] The description has no screenshots or video. This PR replaces the System page, adds a Log levels section and a Task settings page, and reorders the menu, and the repo's guidelines ask for before and after screenshots on UI changes (CLAUDE.md).

Two notes for the maintainers, not blockers: Log levels and Clear cache now sit behind system.manage (the Diagnostics route), while saving them needs config.core.write, so a custom role with only the second loses them. The check against music-assistant/backlog#505 isn't finished yet; a maintainer will confirm whether a Home Assistant row on System and an AI menu entry belong in this PR or a later one.

@marcelveldt
marcelveldt force-pushed the t3/settings-library-metadata-pages branch from a9014ad to 2a3a6a7 Compare November 18, 2026 23:00
Base automatically changed from t3/settings-library-metadata-pages to main November 18, 2026 23:03
@marcelveldt
marcelveldt force-pushed the t3/settings-system-hub branch from f073184 to c5cad70 Compare November 18, 2026 23:03
@marcelveldt
marcelveldt marked this pull request as ready for review November 18, 2026 23:03
@marcelveldt
marcelveldt merged commit 00afb7a into main Nov 18, 2026
14 checks passed
@marcelveldt
marcelveldt deleted the t3/settings-system-hub branch November 18, 2026 23:07
trudenboy pushed a commit to trudenboy/ma-server that referenced this pull request Nov 19, 2026
Update music-assistant-frontend to version
[2.17.375](https://github.com/music-assistant/frontend/releases/tag/2.17.375)


## 🚀 Features and enhancements

- System becomes a hub, with all log levels on Diagnostics (by
@marcelveldt in
[music-assistant#3231](music-assistant/frontend#3231))
- Library options under Music sources and metadata settings under
Metadata sources (by @marcelveldt in
[music-assistant#3229](music-assistant/frontend#3229))
- Connect Home Assistant from the setup wizard (by @marcelveldt in
[music-assistant#3238](music-assistant/frontend#3238))
- Group devices on the Players page and add a Playback page (by
@marcelveldt in
[music-assistant#3226](music-assistant/frontend#3226))
- Offer the apps that play to Music Assistant in the setup wizard (by
@marcelveldt in
[music-assistant#3237](music-assistant/frontend#3237))
- Show the network settings together on one Network page (by
@marcelveldt in
[music-assistant#3223](music-assistant/frontend#3223))
- Audio analysis and background tasks each get one place in Settings (by
@marcelveldt in
[music-assistant#3222](music-assistant/frontend#3222))
- Open the page a plugin serves from the main menu (by @marcelveldt in
[music-assistant#3241](music-assistant/frontend#3241))
- Split off an output from its own row in the player settings (by
@marcelveldt in
[music-assistant#3247](music-assistant/frontend#3247))
- Open author and narrator pages under Audiobooks, link them in
collections (by @fmunkes in
[music-assistant#3235](music-assistant/frontend#3235))
- Drag the Marketplace rows with the mouse (by @OzGav in
[music-assistant#3230](music-assistant/frontend#3230))
- Show a set of speakers as a multi-channel player with its layout (by
@marcelveldt in
[music-assistant#3221](music-assistant/frontend#3221))
- Let the server refuse stale playlist edits and drop the client-side
locks (by @pierosavi in
[music-assistant#3103](music-assistant/frontend#3103))
- Add the queue to a new or existing playlist (by @pierosavi in
[music-assistant#3130](music-assistant/frontend#3130))

## 🐛 Bugfixes

- Always show the close chevron on the fullscreen player (by @pierosavi
in [music-assistant#3248](music-assistant/frontend#3248))
- Fix the volume slider ignoring the mouse on touchscreen PCs (by
@MarvinSchenkel in
[music-assistant#3242](music-assistant/frontend#3242))
- Chunk oversized API commands over remote access (by @jozefKruszynski
in [music-assistant#3160](music-assistant/frontend#3160))
- Show the right items after changing a Discover row's source filter (by
@OzGav in
[music-assistant#3232](music-assistant/frontend#3232))
- Leave switched-off EQ bands out of the graph's total line (by @OzGav
in [music-assistant#3239](music-assistant/frontend#3239))
- Show only library audiobooks in the library row of an author page (by
@jdaberkow in
[music-assistant#3224](music-assistant/frontend#3224))

## 🧰 Maintenance and dependency bumps

- Load no remote images from provider text (by @marcelveldt in
[music-assistant#3240](music-assistant/frontend#3240))


## 🙇 Contributors

@fmunkes, @jdaberkow, @jozefKruszynski, @marcelveldt, @MarvinSchenkel,
@OzGav, @pierosavi and @claude

Co-authored-by: musicassistant-bot[bot] <304008617+musicassistant-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants