Repository navigation
System becomes a hub, with all log levels on Diagnostics - #3231
Conversation
|
@Bot-MArley review |
Bot-MArley
left a comment
There was a problem hiding this comment.
Note
This comment was written by Claude and posted by Bot-MArley on behalf of the Music Assistant maintainers.
This turns System into a hub with rows to Network, Background tasks and Diagnostics, moves every module's log level to one Log levels section on Diagnostics, and gives Task settings their own page. The code looks solid: saving a log level sends only that key, and the server keeps the module's other values. Self-registration follows the entry's category, so it works before and after music-assistant/server#7889.
Requested changes
- [PROBLEM] The description has no screenshots or video. This PR replaces the System page, adds a Log levels section and a Task settings page, and reorders the menu, and the repo's guidelines ask for before and after screenshots on UI changes (CLAUDE.md).
Two notes for the maintainers, not blockers: Log levels and Clear cache now sit behind system.manage (the Diagnostics route), while saving them needs config.core.write, so a custom role with only the second loses them. The check against music-assistant/backlog#505 isn't finished yet; a maintainer will confirm whether a Home Assistant row on System and an AI menu entry belong in this PR or a later one.
a9014ad to
2a3a6a7
Compare
f073184 to
c5cad70
Compare
Update music-assistant-frontend to version [2.17.375](https://github.com/music-assistant/frontend/releases/tag/2.17.375) ## 🚀 Features and enhancements - System becomes a hub, with all log levels on Diagnostics (by @marcelveldt in [music-assistant#3231](music-assistant/frontend#3231)) - Library options under Music sources and metadata settings under Metadata sources (by @marcelveldt in [music-assistant#3229](music-assistant/frontend#3229)) - Connect Home Assistant from the setup wizard (by @marcelveldt in [music-assistant#3238](music-assistant/frontend#3238)) - Group devices on the Players page and add a Playback page (by @marcelveldt in [music-assistant#3226](music-assistant/frontend#3226)) - Offer the apps that play to Music Assistant in the setup wizard (by @marcelveldt in [music-assistant#3237](music-assistant/frontend#3237)) - Show the network settings together on one Network page (by @marcelveldt in [music-assistant#3223](music-assistant/frontend#3223)) - Audio analysis and background tasks each get one place in Settings (by @marcelveldt in [music-assistant#3222](music-assistant/frontend#3222)) - Open the page a plugin serves from the main menu (by @marcelveldt in [music-assistant#3241](music-assistant/frontend#3241)) - Split off an output from its own row in the player settings (by @marcelveldt in [music-assistant#3247](music-assistant/frontend#3247)) - Open author and narrator pages under Audiobooks, link them in collections (by @fmunkes in [music-assistant#3235](music-assistant/frontend#3235)) - Drag the Marketplace rows with the mouse (by @OzGav in [music-assistant#3230](music-assistant/frontend#3230)) - Show a set of speakers as a multi-channel player with its layout (by @marcelveldt in [music-assistant#3221](music-assistant/frontend#3221)) - Let the server refuse stale playlist edits and drop the client-side locks (by @pierosavi in [music-assistant#3103](music-assistant/frontend#3103)) - Add the queue to a new or existing playlist (by @pierosavi in [music-assistant#3130](music-assistant/frontend#3130)) ## 🐛 Bugfixes - Always show the close chevron on the fullscreen player (by @pierosavi in [music-assistant#3248](music-assistant/frontend#3248)) - Fix the volume slider ignoring the mouse on touchscreen PCs (by @MarvinSchenkel in [music-assistant#3242](music-assistant/frontend#3242)) - Chunk oversized API commands over remote access (by @jozefKruszynski in [music-assistant#3160](music-assistant/frontend#3160)) - Show the right items after changing a Discover row's source filter (by @OzGav in [music-assistant#3232](music-assistant/frontend#3232)) - Leave switched-off EQ bands out of the graph's total line (by @OzGav in [music-assistant#3239](music-assistant/frontend#3239)) - Show only library audiobooks in the library row of an author page (by @jdaberkow in [music-assistant#3224](music-assistant/frontend#3224)) ## 🧰 Maintenance and dependency bumps - Load no remote images from provider text (by @marcelveldt in [music-assistant#3240](music-assistant/frontend#3240)) ## 🙇 Contributors @fmunkes, @jdaberkow, @jozefKruszynski, @marcelveldt, @MarvinSchenkel, @OzGav, @pierosavi and @claude Co-authored-by: musicassistant-bot[bot] <304008617+musicassistant-bot[bot]@users.noreply.github.com>
What does this implement/fix?
System was a list of technical modules, and the log level of each module sat on whichever page showed that module. System is now the place for running the server, like the System page in Home Assistant, and all log levels are set together on Diagnostics.
Builds on #3229.
Tested live in a preview build together with the rest of the Settings restructure, so no screenshots.
Related issue (if applicable):
Related backend PR (if applicable):
Types of changes
bugfixnew-featureenhancementbreaking-changerefactormaintenancecidependenciesChecklist
pnpm lint:checkpasses.pnpm test:runpasses, and tests have been added/updated where applicable.pnpm buildpasses.