Skip to content

Always show the close chevron on the fullscreen player - #3248

Merged
OzGav merged 2 commits into
mainfrom
fullscreen-player-close-chevron
Nov 18, 2026
Merged

OzGav merged 2 commits into
mainfrom
fullscreen-player-close-chevron

Conversation

@pierosavi

@pierosavi pierosavi commented Nov 18, 2026 •

Copy link
Copy Markdown
Member

What does this implement/fix?

The fullscreen player hid its close chevron whenever store.mobileLayout was true (phones, and tablets via the tablet user agent). There, the drag handle and a swipe down were the only ways to close the player.

In kiosk WebViews like Fully Kiosk Browser with Enable Pull to Refresh turned on, the app's native pull-to-refresh catches that swipe before the page sees it. The page reloads, and the player can't be closed at all. PanelDragHandle already calls preventDefault on touchmove, which stops Chrome's own pull-to-refresh but can't stop a native refresh layout.

This keeps the chevron visible in every layout, next to the drag handle. That also gives keyboard and screen-reader users a labelled close button instead of a gesture only.

I reproduced it on an Android 13 emulator (WebView 109) running Fully Kiosk 1.61.4 with Pull to Refresh on, at both tablet (1280×800) and phone (360×760 dp) sizes. Before the change, a swipe reloaded the page. After it, the chevron shows and tapping it closes the player. It was also verified on a real phone.

Before After
Tablet Tablet before: no chevron Tablet after: chevron shown
Phone Phone before: swipe triggers a reload Phone after: chevron shown

Related issue (if applicable):

Types of changes

  • Bugfix (non-breaking change which fixes an issue) — bugfix
  • New feature (non-breaking change which adds functionality) — new-feature
  • Enhancement to an existing feature — enhancement
  • Breaking change (fix or feature that would cause existing functionality to not work as expected) — breaking-change
  • Refactor (no behaviour change) — refactor
  • Maintenance / chore — maintenance
  • CI / workflow change — ci
  • Dependencies bump — dependencies

Checklist

  • The code change is tested and works locally.
  • pnpm lint:check passes.
  • pnpm test:run passes, and tests have been added/updated where applicable. (7252 passed; template-only change, no new tests)
  • pnpm build passes.
  • I have read and complied with the project's AI Policy for any AI-assisted contributions.

On tablets and in kiosk WebViews (Fully Kiosk with Pull to Refresh) the
drag handle was the only way to close the player, and a swipe down was
caught by the native pull-to-refresh, reloading the page.

@Bot-MArley Bot-MArley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

This comment was written by Claude and posted by Bot-MArley on behalf of the Music Assistant maintainers.

Thanks @pierosavi! This keeps the close chevron visible on phones and tablets too, so the fullscreen player can still be closed when a kiosk WebView turns the swipe down into a pull-to-refresh, and it gives keyboard and screen-reader users a labelled close button. The chevron sits in the toolbar below the drag handle, so the two don't clash, and the screenshots show it at both sizes.

This looks good to me. It's ready for a maintainer to merge.

@OzGav OzGav left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simples!

@OzGav
OzGav enabled auto-merge (squash) November 18, 2026 23:14
@OzGav
OzGav merged commit 41d6ce3 into main Nov 18, 2026
13 checks passed
@OzGav
OzGav deleted the fullscreen-player-close-chevron branch November 18, 2026 23:17
trudenboy pushed a commit to trudenboy/ma-server that referenced this pull request Nov 19, 2026
Update music-assistant-frontend to version
[2.17.375](https://github.com/music-assistant/frontend/releases/tag/2.17.375)


## 🚀 Features and enhancements

- System becomes a hub, with all log levels on Diagnostics (by
@marcelveldt in
[music-assistant#3231](music-assistant/frontend#3231))
- Library options under Music sources and metadata settings under
Metadata sources (by @marcelveldt in
[music-assistant#3229](music-assistant/frontend#3229))
- Connect Home Assistant from the setup wizard (by @marcelveldt in
[music-assistant#3238](music-assistant/frontend#3238))
- Group devices on the Players page and add a Playback page (by
@marcelveldt in
[music-assistant#3226](music-assistant/frontend#3226))
- Offer the apps that play to Music Assistant in the setup wizard (by
@marcelveldt in
[music-assistant#3237](music-assistant/frontend#3237))
- Show the network settings together on one Network page (by
@marcelveldt in
[music-assistant#3223](music-assistant/frontend#3223))
- Audio analysis and background tasks each get one place in Settings (by
@marcelveldt in
[music-assistant#3222](music-assistant/frontend#3222))
- Open the page a plugin serves from the main menu (by @marcelveldt in
[music-assistant#3241](music-assistant/frontend#3241))
- Split off an output from its own row in the player settings (by
@marcelveldt in
[music-assistant#3247](music-assistant/frontend#3247))
- Open author and narrator pages under Audiobooks, link them in
collections (by @fmunkes in
[music-assistant#3235](music-assistant/frontend#3235))
- Drag the Marketplace rows with the mouse (by @OzGav in
[music-assistant#3230](music-assistant/frontend#3230))
- Show a set of speakers as a multi-channel player with its layout (by
@marcelveldt in
[music-assistant#3221](music-assistant/frontend#3221))
- Let the server refuse stale playlist edits and drop the client-side
locks (by @pierosavi in
[music-assistant#3103](music-assistant/frontend#3103))
- Add the queue to a new or existing playlist (by @pierosavi in
[music-assistant#3130](music-assistant/frontend#3130))

## 🐛 Bugfixes

- Always show the close chevron on the fullscreen player (by @pierosavi
in [music-assistant#3248](music-assistant/frontend#3248))
- Fix the volume slider ignoring the mouse on touchscreen PCs (by
@MarvinSchenkel in
[music-assistant#3242](music-assistant/frontend#3242))
- Chunk oversized API commands over remote access (by @jozefKruszynski
in [music-assistant#3160](music-assistant/frontend#3160))
- Show the right items after changing a Discover row's source filter (by
@OzGav in
[music-assistant#3232](music-assistant/frontend#3232))
- Leave switched-off EQ bands out of the graph's total line (by @OzGav
in [music-assistant#3239](music-assistant/frontend#3239))
- Show only library audiobooks in the library row of an author page (by
@jdaberkow in
[music-assistant#3224](music-assistant/frontend#3224))

## 🧰 Maintenance and dependency bumps

- Load no remote images from provider text (by @marcelveldt in
[music-assistant#3240](music-assistant/frontend#3240))


## 🙇 Contributors

@fmunkes, @jdaberkow, @jozefKruszynski, @marcelveldt, @MarvinSchenkel,
@OzGav, @pierosavi and @claude

Co-authored-by: musicassistant-bot[bot] <304008617+musicassistant-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Minimise from full screen now-playing control not visible on some tablets.

3 participants