Repository navigation
Conversation
seadowg
force-pushed
the
settings-sections
branch
from
November 17, 2026 14:31
1d4326d to
582c7a0
Compare
seadowg
force-pushed
the
settings-sections
branch
from
November 18, 2026 13:19
fec6a08 to
2ed8220
Compare
Collaborator
Author
|
@remon1496 @formatBCE this is a first draft that I think is worth us all having a play with (I've got it running on my phone) to see if we can find any issues! I suspect there's a few disconnect/reconnect flows we don't have tests for, so we can hopefully tease those out here. |
Collaborator
|
Try logging in and out several times with different methods. I'm catching some glitch like I'm connected, logged in, but still staying on that screen. Closing screen (either with "x" or with back gesture) just closes the app. It resolves after - but still glitchy. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First step to reworking the settings UI to have sections is to create a dedicated connection screen that shows when the app is disconnected or logged out. Otherwise, we'd have to design special flows for the nested settings sections when the app is disconnected/logged out.
Is there anything about the code changes here that should be highlighted?
Are there any additional changes not related to the issue above?
Before submitting this PR, make sure you have:
./gradlew detektAll testAndroidHostTest :androidApp:testDebug