Skip to content

Add connection screen - #1405

Draft
seadowg wants to merge 13 commits into
music-assistant:mainfrom
seadowg:settings-sections
Draft

seadowg wants to merge 13 commits into
music-assistant:mainfrom
seadowg:settings-sections

Conversation

@seadowg

@seadowg seadowg commented Nov 17, 2026 •

Copy link
Copy Markdown
Collaborator

First step to reworking the settings UI to have sections is to create a dedicated connection screen that shows when the app is disconnected or logged out. Otherwise, we'd have to design special flows for the nested settings sections when the app is disconnected/logged out.

Is there anything about the code changes here that should be highlighted?

Are there any additional changes not related to the issue above?

Before submitting this PR, make sure you have:

  • Given this PR a readable name that can be used in the app's changelog
  • Made sure checks pass by running ./gradlew detektAll testAndroidHostTest :androidApp:testDebug

@seadowg

seadowg commented Nov 18, 2026 •

Copy link
Copy Markdown
Collaborator Author

@remon1496 @formatBCE this is a first draft that I think is worth us all having a play with (I've got it running on my phone) to see if we can find any issues! I suspect there's a few disconnect/reconnect flows we don't have tests for, so we can hopefully tease those out here.

@formatBCE

Copy link
Copy Markdown
Collaborator

Try logging in and out several times with different methods. I'm catching some glitch like I'm connected, logged in, but still staying on that screen. Closing screen (either with "x" or with back gesture) just closes the app. It resolves after - but still glitchy.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants