Repository navigation
Correct the Pyodide ceiling claim - #1463
Merged
Merged
Conversation
Both the memory entry and the eegprep-lean contract said every dependency floor is a ceiling in the browser. That is only true of compiled packages. The test is whether the package publishes a pure-Python wheel, not whether Pyodide bundles it. A py3-none-any wheel means micropip fetches any version straight from PyPI and the bundled build goes unused. numpy, scipy, h5py and matplotlib publish none and are genuinely capped; threadpoolctl is bundled but pure Python and is not. The memory cited threadpoolctl>=3.6.0 on the epic branch as a live broken install, which was wrong. Kept as the instructive part rather than quietly deleted: being bundled made it look identical to the scipy case, and presence in pyodide-lock.json says nothing about whether another version is reachable. Over-applying the rule has its own cost, which is false alarms and a guard nobody trusts. Superseded claims removed rather than left beside the correction, per the directory's own rules. Test fix is sccn/eegprep#402.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
.memoryentry and theeegprep-leancontract, both merged earlier today, said that everydependency floor is a ceiling in the browser. That is only true of compiled packages, and I should
not have generalized it.
The correction
The test is whether the package publishes a pure-Python wheel, not whether Pyodide bundles it.
A
py3-none-anywheel means micropip fetches any version straight from PyPI and the bundled buildgoes unused, so the floor costs a download and nothing more.
py3-none-anyWhy the mistake is kept rather than quietly deleted
The memory cited
threadpoolctl>=3.6.0on the epic branch as a live broken install. It is not one.Being bundled by Pyodide made it look identical to the scipy case, and that is the instructive
part: presence in
pyodide-lock.jsonsays nothing about whether another version is reachable.The entry now states what was wrong and why it looked right, and the superseded claim is removed
rather than left beside the correction, per the directory's own rules. It also records that
over-applying the rule has its own cost, which is false alarms on pure-Python packages and a guard
nobody trusts.
The corresponding test fix is sccn/eegprep#402, and sccn/eegprep#400 carries the same correction
as a comment.