Repository navigation
Conversation
ci7lus
force-pushed
the
mmtlv2
branch
9 times, most recently
from
August 31, 2026 16:28
d5d713e to
30b7d43
Compare
VLCAudio retains the underlying libvlc media player so it can outlive its VLCMediaPlayer wrapper. The libvlc callbacks still use the wrapper's VLCEventsHandler through an unretained opaque pointer, which can become dangling when a late state change is delivered during shutdown. Retain the event handler alongside the libvlc player in VLCAudio. The handler keeps its target weak, so this preserves the callback context without extending the VLCMediaPlayer lifetime. Add a regression test covering audio outliving its media player.
ci7lus
marked this pull request as ready for review
September 1, 2026 12:09
ci7lus
enabled auto-merge
September 1, 2026 12:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mmt/tlvのメタデータのパースを行います neneka/vlc@54606c1