Repository navigation
Conversation
The northbound API creates provisioning requests, and the role had no create verb for them. Status and finalizers are separate rules now. The admission rule named admissionregistration.k8s.io/v1 as a group, which is not one, so it granted nothing; no handler registers a webhook, so it is removed. The deployment gets liveness and readiness probes on kopf's /healthz, which answers 500 when the northbound API does not accept a connection. The API listens on loopback, so it gets no port. Signed-off-by: thc1006 <84045975+thc1006@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to nephio-project/nephio#1197. Please keep this as a draft until #1197 is merged and its image is built.
rbac.yaml: the northbound API creates provisioning requests, and the role had nocreatefor them. Status and finalizers are separate rules now. The admission rule namedadmissionregistration.k8s.io/v1as a group, which is not a group, so it granted nothing. No handler registers a webhook, so it is removed.deployment.yaml: liveness and readiness probes on kopf's/healthz, which answers 500 when the northbound API does not accept a connection. The API listens on loopback, so it gets no port and no Service.Before merging, the image has to move from
2097228064147640320to the build of #1197. The current image does not pass--liveness, so with these probes it would be restarted again and again. I will update the tag here once that build exists.Both files pass
kubectl apply --dry-run=serveragainst a kube-apiserver. With the old role,kubectl auth can-i create provisioningrequestsas the operator's service account answersno; with this one it answersyes.Thank you for taking a look.