Improve file retrieval logic in DependencyChecker - #331
Open
ViPErCZ wants to merge 8 commits into
Open
Conversation
…ile locks On Windows, rename() over an existing cached container file intermittently fails with "Access is denied" when the target is momentarily locked by another process (antivirus scanning the freshly written file, or a memory-mapped opcache handle). Unlike POSIX, the replace is not atomic against open handles. Extracts the tmp-write + rename into atomicWrite(), which now drops the target's opcache handle before renaming and, on Windows only, retries the rename a few times with a short backoff. On other platforms behavior is unchanged — a single rename failure still throws immediately. Fixes flaky ContainerLoader.hotReload.
Refactor file retrieval for ReflectionClass instances.
dg
force-pushed
the
v3.2
branch
6 times, most recently
from
August 27, 2026 01:13
45b243b to
7b00ce1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor file retrieval for ReflectionClass instances.
in PHP 8+ filemtime in strict_types=1 mode => filemtime(): Argument #1 ($filename) must be of type string, false given