Add Redis server example - #2
Open
trustin wants to merge 1 commit into
Open
Conversation
Motivation:
- We have a Redis client example, but not its server counterpart.
- This repository is not very usable at its current form because it
depends on Netty 5.0.0.Final-SNAPSHOT which is actually very outdated.
Modifications:
- Revert the repository to use Netty 4.1.
- Add `RedisServer` and `RedisServerHandler` which demonstrate how to
write a server that understands RESP.
- Currently supports GET, SET, DEL and SHUTDOWN command in a very
simplistic form.
Result:
- This repository now builds without failure.
- This repository now uses the Netty version that's actually up to date.
- We now have a Redis server example, as well as a client-side one.
Contributor
|
For Netty 4.1, we have the redis code in our main netty/netty repository. This contrib repo is here so we could remove that module from the Netty 5 |
Author
|
@chrisvest Then shall I send a PR to |
Contributor
|
@trustin For adding an example server based on 4.1, I think that's the correct place. |
|
@trustin I'd like to continue this on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
Modifications:
RedisServerandRedisServerHandlerwhich demonstrate how to write a server that understands RESP.Result: