Notificationblock: grey icon - #2066
Merged
Merged
Conversation
marcustyphoon
changed the title
marcustyphoon
changed the title
AprilSylph
requested changes
Jun 2, 2021
AprilSylph
left a comment
AprilSylph
left a comment
There was a problem hiding this comment.
needs extension version bump to 1.4.1
yikes I have not interacted with this repo in a while
AprilSylph
approved these changes
Jun 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the notificationblock icon grey. It doesn't do anything else.
It actually makes Postblock and Notificationblock kind of hard to tell apart, to be honest, but I dunno what we can easily do about that besides maybe having scratchyone do another #2054 (which, unfortunately, would still have to be grey unless someone wants to rewrite
interface.react.create_control_buttonto not use a background image. XKit Rewritten avoids this by just adding an item to the meatball menu for these kinds of functions.)The "ok" icon seems fine as-is, since it's green and that shows up fine on all of the themes.