feat(ui): promote archive to an envelope primary action#13295
Open
mrx8086 wants to merge 1 commit into
Open
Conversation
|
Thanks for opening your first pull request in this repository! ✌️ |
Member
|
Thank you for the contribution @nimishavijay fine by you? @mrx8086 please describe the changes in your words next time and don't use AI for the PR description: https://github.com/nextcloud/.github/blob/master/CONTRIBUTING.md#ai-assisted-contributions |
Favorite, read and important are available as one-click primary actions on the envelope menu, but archiving - a core step of inbox-zero style workflows - is buried further down the list. Promote the existing archive entry to a fourth primary action button so it is reachable with a single click, reusing the existing onArchive() handler, showArchiveButton/disableArchiveButton logic and ACL checks. The button only shows when an archive mailbox is configured and the account has the required ACLs, mirroring the previous menu entry. No new translatable strings are introduced. Assisted-by: ClaudeCode:claude-fable-5 Signed-off-by: Mathias Riechsteiner <mathias@riechsteiner.online>
mrx8086
force-pushed
the
feat/ui/archive-primary-action
branch
from
e4f8583 to
d9092b5
Compare
Author
|
Thank you, and sorry about that — I'll write the descriptions and replies personally going forward. The commit trailer is updated to the current |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Favorite, read and important are available as one-click primary action
buttons at the top of the envelope actions menu, but archiving — a core
step of inbox-zero style workflows — sits further down the entry list.
This PR promotes the existing archive entry to a fourth primary action
button:
onArchive()handler,showArchiveButton/disableArchiveButtoncomputed properties and thehasArchiveAclcheck — no behavioral changes.
account and the ACLs allow it, exactly like the previous menu entry.
the same action does not appear twice in one open menu.
"Archive message" strings are reused.
If the design team prefers to keep the primary row at three buttons, I
am happy to adjust (e.g. make the fourth button conditional or move it
behind a setting) — feedback welcome.
Screenshots
Screenshots of the envelope actions menu before/after will follow.
Checklist
npx eslint src/components/Envelope.vue— no new warnings)npm run build)AI-assistedtrailer are added