Repository navigation
Conversation
Uploads keep the mtime of the file they come from, so a file uploaded today with an older mtime was not recent for getRecent(), while the Files app's recent view, which looks at the upload time as well, shows it. Use the same last activity, the later of both, here. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: John Molakvoæ <14975046+skjnldsv@users.noreply.github.com>
skjnldsv
requested review from
Altahrim,
icewind1991 and
leftybournes
and removed request for
a team
October 29, 2026 07:11
The last activity order was built as raw SQL, `COALESCE(fe.upload_time, 0)`, so Oracle read the unquoted name as "FE"."UPLOAD_TIME" and failed with ORA-00904. Build it with the function builder, which quotes it. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: John Molakvoæ <14975046+skjnldsv@users.noreply.github.com>
Oracle binds the parameter as text, and COALESCE refuses to mix it with the number column (ORA-00932). The default is a constant, so write it in the query. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: John Molakvoæ <14975046+skjnldsv@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#58327 made the Files app's Recent view look at upload time, since an upload keeps the mtime the file had on the uploader's device.
Folder::getRecent()was left on mtime only, so a photo taken last month and uploaded today is in Files > Recent but not ingetRecent().This follows up on #58327:
getRecent()now also takes files uploaded in the last two weeks, and orders by last activity, the later of mtime and upload time. Recommendations' "recently edited" source is built on it, and the legacy/apps/files/api/v1/recentendpoint too.To reproduce, upload a file with an old mtime:
It's in Files > Recent, but not in
getRecent()or the recommendations.The new test fails without the change.
Checklist
3. to review, feature component)stable32)AI (if applicable)
👾 This pull request was assisted by Claude Code, commits carry an
Assisted-bytrailer.