fix(editor): set translate=yes for read-only editor - #8962
Merged
Conversation
github-project-automation
Bot
moved this to 馃Л Planning evaluation (don't pick)
in 馃摑 Productivity team
mejo-
moved this from 馃Л Planning evaluation (don't pick)
to 馃憖 In review
in 馃摑 Productivity team
grnd-alt
approved these changes
Aug 4, 2026
mejo-
force-pushed
the
fix/readonly_allow_translate
branch
from
August 4, 2026 14:00
34c1b1d to
b4018a8
Compare
Member
Author
|
/backport to stable34 |
max-nextcloud
requested changes
Aug 5, 2026
max-nextcloud
left a comment
max-nextcloud
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for tackling this! 鉂わ笍
I have two requests for changes.
mejo-
force-pushed
the
fix/readonly_allow_translate
branch
from
August 5, 2026 07:47
b4018a8 to
fd64738
Compare
max-nextcloud
approved these changes
Aug 5, 2026
max-nextcloud
left a comment
max-nextcloud
left a comment
Collaborator
There was a problem hiding this comment.
Looks good now.
Just a linter issue remaining.
Tells browsers to translate the editor content despite it being a `contenteditable` element. Fixes: nextcloud/collectives#2666 Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: OpenCode:claude-fable-5 Signed-off-by: Jonas <jonas@freesources.org>
mejo-
force-pushed
the
fix/readonly_allow_translate
branch
from
August 5, 2026 08:08
fd64738 to
168944b
Compare
github-project-automation
Bot
moved this from 馃憖 In review
to 鈽戯笍 Done
in 馃摑 Productivity team
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tells browsers to translate the editor content despite it being a
contenteditableelement.Fixes: nextcloud/collectives#2666
Assisted-by: OpenCode:claude-fable-5
馃弫 Checklist
npm run lint/npm run stylelint/composer run cs:check)馃 AI (if applicable)