Repository navigation
Fixes an inconsistency in cmake library consumption - #100
Open
dlarsson-adobe wants to merge 1 commit into
Open
dlarsson-adobe wants to merge 1 commit into
dlarsson-adobe wants to merge 1 commit into
Conversation
When using include(<spzdir>) headers are expected to be included as <spz-header.h> When using find_package(spz) on the exported cmake-configuration headers are expected to be included as <spz/spz-header.h> This change makes all headers include consistently in the second way by using target_include_directory instead of relying on relative locations of headers
dlarsson-adobe
requested review from
ProjitB,
azadbal and
daniel-niantic-spatial
as code owners
July 15, 2026 20:11
lukeyreyno
self-requested a review
July 15, 2026 23:36
lukeyreyno
approved these changes
Jul 15, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using include(<spzdir>) in cmake headers are expected to be included as <spz-header.h>
When using find_package(spz) on the exported cmake-configuration headers are expected to be included as <spz/spz-header.h>
This change makes all headers include consistently in the second way by using target_include_directory instead of relying on relative locations of headers.
Also see #99 which does this in a less intrusive way