Skip to content

Revise SEPBENCHSLOWONES and skip in Release and hence ReadLine benchmarks going forward #643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nietras merged 1 commit into from
Nov 3, 2026
Merged

Revise SEPBENCHSLOWONES and skip in Release and hence ReadLine benchmarks going forward #643

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
<SuppressNETCoreSdkPreviewMessage>true</SuppressNETCoreSdkPreviewMessage>

<!--<DefineConstants Condition="'$(Configuration)'=='Release'">$(DefineConstants);SEPBENCHSEPONLY</DefineConstants>-->
<DefineConstants Condition="'$(Configuration)'=='Release'">$(DefineConstants);SEPBENCHSLOWONES</DefineConstants>
<!--<DefineConstants Condition="'$(Configuration)'=='Release'">$(DefineConstants);SEPBENCHSLOWONES</DefineConstants>-->
<DefineConstants Condition="'$(Configuration)'=='Debug'">$(DefineConstants);SEPASSERT</DefineConstants>
<!--<DefineConstants Condition="'$(Configuration)'=='Debug'">$(DefineConstants);SEPTRACE</DefineConstants>-->
<DefineConstants Condition="'$(Configuration)'=='Debug'">$(DefineConstants);SEPREADERASSERT</DefineConstants>
Expand Down
6 changes: 3 additions & 3 deletions src/Sep.ComparisonBenchmarks/FloatsReaderBench.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ public void ReadLine_()
}
}

#if SEPBENCHSLOWONES && !SEPBENCHSEPONLY
#if !SEPBENCHSEPONLY
[Benchmark]
#endif
public void CsvHelper()
Expand Down Expand Up @@ -190,7 +190,7 @@ public void ReadLine_()
}
}

#if SEPBENCHSLOWONES && !SEPBENCHSEPONLY
#if !SEPBENCHSEPONLY
[Benchmark]
#endif
public void CsvHelper()
Expand Down Expand Up @@ -373,7 +373,7 @@ public double ReadLine_()
return sum / count;
}

#if SEPBENCHSLOWONES && !SEPBENCHSEPONLY
#if !SEPBENCHSEPONLY
[Benchmark]
#endif
public double CsvHelper()
Expand Down
10 changes: 5 additions & 5 deletions src/Sep.ComparisonBenchmarks/PackageAssetsBench.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ public void ReadLine_()
}
}

#if SEPBENCHSLOWONES && !SEPBENCHSEPONLY
#if !SEPBENCHSEPONLY
[Benchmark]
#endif
public void CsvHelper()
Expand Down Expand Up @@ -211,7 +211,7 @@ public void Sep_TrimUnescapeTrim()
}
}

#if SEPBENCHSLOWONES && !SEPBENCHSEPONLY
#if !SEPBENCHSEPONLY
[Benchmark]
#endif
public void CsvHelper_TrimUnescape()
Expand All @@ -237,7 +237,7 @@ public void CsvHelper_TrimUnescape()
}
}

#if SEPBENCHSLOWONES && !SEPBENCHSEPONLY
#if !SEPBENCHSEPONLY
[Benchmark]
#endif
public void CsvHelper_TrimUnescapeTrim()
Expand Down Expand Up @@ -351,7 +351,7 @@ public void ReadLine_()
}
}

#if SEPBENCHSLOWONES && !SEPBENCHSEPONLY
#if !SEPBENCHSEPONLY
[Benchmark]
#endif
public void CsvHelper()
Expand Down Expand Up @@ -482,7 +482,7 @@ public void ReadLine_()
}
}

#if SEPBENCHSLOWONES && !SEPBENCHSEPONLY
#if !SEPBENCHSEPONLY
[Benchmark]
#endif
public void CsvHelper()
Expand Down
Loading