doc: add inline comment hints on finalizer signatures#1738
Open
legendecas wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1738 +/- ##
=======================================
Coverage 63.69% 63.69%
=======================================
Files 3 3
Lines 2063 2063
Branches 730 730
=======================================
Hits 1314 1314
Misses 162 162
Partials 587 587 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
alexweej
reviewed
Jul 14, 2026
| #endif // NAPI_VERSION > 8 | ||
|
|
||
| #ifdef NODE_API_EXPERIMENTAL_HAS_POST_FINALIZER | ||
| // FinalizerType must implement `void operator()(Env env)`. |
There was a problem hiding this comment.
Have we considered using C++ Concepts for this instead of these human-only annotations?
There was a problem hiding this comment.
(Though clearly this doesn't need to block the PR...)
Member
Author
There was a problem hiding this comment.
it will be a semver-major to bump minimum c++ version to c++20. Right now node-addon-api still supports c++17 as in node v18/v20
Line 478 in 13c28f6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add inline comment hints on finalizer signatures.