Skip to content

test_runner: create reporter destination directories - #65008

Open
Aston8 wants to merge 2 commits into
nodejs:mainfrom
Aston8:fix/test-reporter-destination-create-parent
Open

test_runner: create reporter destination directories#65008
Aston8 wants to merge 2 commits into
nodejs:mainfrom
Aston8:fix/test-reporter-destination-create-parent

Conversation

@Aston8

@Aston8 Aston8 commented Aug 4, 2026

Copy link
Copy Markdown

This creates missing parent directories before opening file-backed --test-reporter-destination outputs, so paths like coverage/lcov.info no longer fail with ENOENT when the parent directory does not exist.

It also adds a regression test for a nested reporter destination path.

Fixes #64994

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Aug 4, 2026
Comment thread lib/internal/test_runner/utils.js Outdated
Co-authored-by: Aviv Keller <me@aviv.sh>
@Aston8
Aston8 requested a review from avivkeller August 4, 2026 14:43
@atlowChemi

Copy link
Copy Markdown
Member

@Aston8 AFAICT your commit did not follow the guidelines (and is missing the Signed-Off-By footer)

Please reword the commit to make sure it meets the required standards, and then I would be happy to run CI

@ClementValot

Copy link
Copy Markdown

Bump @Aston8 🙏

@trivikr trivikr changed the title Create parent directories for test reporter destinations test_runner: create reporter destination directories Aug 23, 2026
@trivikr

trivikr commented Aug 23, 2026

Copy link
Copy Markdown
Member

@Aston8 Can you please sign the first commit and force push?

It's required as per instructions

Your commit must contain the Signed-off-by line with your name and email address as an acknowledgement that you agree to the Developer Certificate of Origin.

@codecov

codecov Bot commented Aug 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.28%. Comparing base (fb6693e) to head (e7c01bb).
⚠️ Report is 366 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #65008   +/-   ##
=======================================
  Coverage   90.28%   90.28%           
=======================================
  Files         762      759    -3     
  Lines      247532   247608   +76     
  Branches    46690    46674   -16     
=======================================
+ Hits       223475   223554   +79     
- Misses      15491    15518   +27     
+ Partials     8566     8536   -30     
Files with missing lines Coverage Δ
lib/internal/test_runner/utils.js 66.48% <100.00%> (+0.13%) ⬆️

... and 54 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@trivikr trivikr added the blocked PRs that are blocked by other issues or PRs. label Aug 24, 2026
@trivikr

trivikr commented Aug 24, 2026

Copy link
Copy Markdown
Member

Marked as blocked as PR author @Aston8 needs to sign the first commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocked PRs that are blocked by other issues or PRs. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test runner: --test-reporter-destination should create the folder if not found

7 participants