doc: fix default limit of maxHeadersCount - #65472
Merged
nodejs-github-bot merged 1 commit intoAug 25, 2026
Merged
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
doc
lpinca
approved these changes
Aug 23, 2026
mertcanaltin
approved these changes
Aug 23, 2026
Contributor
|
@arynh Could you update |
pimterry
approved these changes
Aug 24, 2026
pimterry
added
commit-queue
pimterry
requested changes
Aug 24, 2026
pimterry
left a comment
pimterry
left a comment
Member
There was a problem hiding this comment.
Nearly missed @deokjinkim's comment here and merged this, oops!
Adding a blocking review to stop somebody else doing the same, I agree we should update the default consistently on the HTTPS page too.
Contributor
Author
|
Yep I'll update the HTTPS page too, missed that default |
Contributor
Author
|
Updated! Good catch @deokjinkim |
pimterry
approved these changes
Aug 24, 2026
deokjinkim
approved these changes
Aug 24, 2026
deokjinkim
added
author ready
Member
arynh
force-pushed
the
docs/default-header-count-limit
branch
from
August 25, 2026 07:14
0cc576e to
70e7829
Compare
The documented limit of 2000 refers to header pairs (counting both keys and values), which gives an effective limit of 1000 headers. This applies to both client and server; they have the same mechanism. Signed-off-by: Aryn H <arynh@protonmail.com>
arynh
force-pushed
the
docs/default-header-count-limit
branch
from
August 25, 2026 07:15
70e7829 to
471808e
Compare
Contributor
Author
|
got it, squashed then rebased so my branch is just one commit ahead of |
pimterry
approved these changes
Aug 25, 2026
pimterry
added
commit-queue
Collaborator
|
Landed in 056e2ae |
nodejs-github-bot
removed
the
commit-queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The documented limit of 2000 refers to header pairs (counting both keys and values), which gives an effective limit of 1000 headers.
This applies to both client and server; they have the same mechanism.
This fixes issue #65470, see the details added there for verification of the discrepancy.