docs: record wave2 Nu 0.114 catalog completion - #85
Conversation
Mark handoff success criteria and consolidated roadmap for the five wave2 plugins published via numan-registry#45. Co-authored-by: Anthony Thompson <github@trackdub.com>
Co-authored-by: Anthony Thompson <github@trackdub.com>
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- In the success criteria checklist, the final item 'Backlog + roadmap docs updated (numan-plugins bookkeeping PR; this file)' is still unchecked even though this PR appears to satisfy it; consider either checking it or clarifying that some follow-up work is still pending.
- You mention Windows prove as 'optional follow-up' in the success criteria; if you plan to run it later, consider adding a brief note or sub-bullet indicating what would mark Windows prove as complete so future readers know when this criterion is fully satisfied.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In the success criteria checklist, the final item 'Backlog + roadmap docs updated (numan-plugins bookkeeping PR; this file)' is still unchecked even though this PR appears to satisfy it; consider either checking it or clarifying that some follow-up work is still pending.
- You mention Windows prove as 'optional follow-up' in the success criteria; if you plan to run it later, consider adding a brief note or sub-bullet indicating what would mark Windows prove as complete so future readers know when this criterion is fully satisfied.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
PR Summary by QodoDocument Wave 2 Nu 0.114 catalog completion and handoff criteria
AI Description
Diagram
High-Level Assessment
Files changed (2)
|
Greptile SummaryThe PR records completion of the Wave 2 Nu 0.114 plugin-promotion handoff.
Confidence Score: 4/5The PR should not merge until the previously reported wave-count inconsistency is reconciled with the contract-pinned roadmap. The current handoff still records five plugins in each wave and ten overall, while the consolidated roadmap enumerates only two Wave 1 packages, leaving the completion record internally inconsistent. Files Needing Attention: docs/plans/handoff-promote-0114-plugins.md
|
| Filename | Overview |
|---|---|
| docs/plans/handoff-promote-0114-plugins.md | Replaces the open handoff checklist with completed Wave 2 publication and lifecycle-validation records and clarifies roadmap bookkeeping. |
Reviews (5): Last reviewed commit: "Merge branch 'master' into cursor/wave2-..." | Re-trigger Greptile
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Code Review by Qodo
1.
|
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
Qodo Fixer✅ Committed (1) · ☑ Fixed (1) Commits pushed directly to this PR — no separate fix PR opened. Process — 1 fixed
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
|
Important Review skippedNo new commits to review since the last review. ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThe handoff document now directs plugin roadmap bookkeeping to the backlog and records completed Wave 1 and Wave 2 promotion criteria for ten plugins, including registry, production, compatibility, lifecycle, and documentation evidence. ChangesNu 0.114 plugin promotion
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 8✅ Passed checks (8 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Warning Review ran into problems🔥 ProblemsLinked repositories: Public OSS repositories can only analyze public repositories installed in this organization. Analyzed Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/plans/consolidated-multi-repo-roadmap.md`:
- Around line 132-140: Regenerate the frozen roadmap contract using
scripts/bump-contract.sh after updating the Wave 2 Nu 0.114 CI-built promotion
section, and include the generated contract changes with this roadmap update. Do
not merge the roadmap addition while the contract remains unsynchronized;
otherwise revert the addition.
In `@docs/plans/handoff-promote-0114-plugins.md`:
- Line 183: Keep the “Backlog + roadmap docs updated” checklist item unchecked
until companion PR numan-plugins#42 merges and its backlog and manifest entries
change from ELIGIBLE to PROMOTED.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 7653a604-2793-42c4-aa2a-8384381f015c
📒 Files selected for processing (2)
docs/plans/consolidated-multi-repo-roadmap.mddocs/plans/handoff-promote-0114-plugins.md
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
tonythethompson/QuickShell(manual)tonythethompson/numan(manual)tonythethompson/dependency-chain-substrate(manual)
📜 Review details
⚠️ CI failures not shown inline (3)
GitHub Actions: CI / Roadmap drift: docs: record wave2 Nu 0.114 catalog completion
Conclusion: failure
##[group]Run ref_file=$(mktemp)
�[36;1mref_file=$(mktemp)�[0m
�[36;1mstatus=$(curl --silent --show-error --output "$ref_file" --write-out "%{http_code}" \�[0m
�[36;1m -H "Authorization: ***" \�[0m
�[36;1m -H "Accept: application/vnd.github+json" \�[0m
�[36;1m -H "User-Agent: numan-ci" \�[0m
�[36;1m "https://api.github.com/repos/tonythethompson/numan/git/refs/tags/${CONTRACT_TAG}")�[0m
�[36;1mif [ "$status" = "404" ]; then�[0m
�[36;1m echo "::warning::Tag $CONTRACT_TAG does not exist yet; skipping SHA resolution check."�[0m
�[36;1m exit 0�[0m
�[36;1mfi�[0m
�[36;1mif [ "$status" != "200" ]; then�[0m
�[36;1m echo "::error::GitHub API returned HTTP $status for tag $CONTRACT_TAG."�[0m
GitHub Actions: CI / Roadmap drift: docs: record wave2 Nu 0.114 catalog completion
Conclusion: failure
##[group]Run curl --fail-with-body --silent --show-error --location \
�[36;1mcurl --fail-with-body --silent --show-error --location \�[0m
�[36;1m https://raw.githubusercontent.com/tonythethompson/numan/$CONTRACT_SHA/docs/plans/consolidated-multi-repo-roadmap.md \�[0m
�[36;1m -o /tmp/consolidated-roadmap.md�[0m
�[36;1mdiff -u docs/plans/consolidated-multi-repo-roadmap.md /tmp/consolidated-roadmap.md \�[0m
�[36;1m || (echo "::error::Local consolidated roadmap diverges from $CONTRACT_SHA."; \�[0m
GitHub Actions: CI / 4_Roadmap drift.txt: docs: record wave2 Nu 0.114 catalog completion
Conclusion: failure
##[group]Run ref_file=$(mktemp)
�[36;1mref_file=$(mktemp)�[0m
�[36;1mstatus=$(curl --silent --show-error --output "$ref_file" --write-out "%{http_code}" \�[0m
�[36;1m -H "Authorization: ***" \�[0m
�[36;1m -H "Accept: application/vnd.github+json" \�[0m
�[36;1m -H "User-Agent: numan-ci" \�[0m
�[36;1m "https://api.github.com/repos/tonythethompson/numan/git/refs/tags/${CONTRACT_TAG}")�[0m
�[36;1mif [ "$status" = "404" ]; then�[0m
�[36;1m echo "::warning::Tag $CONTRACT_TAG does not exist yet; skipping SHA resolution check."�[0m
�[36;1m exit 0�[0m
�[36;1mfi�[0m
�[36;1mif [ "$status" != "200" ]; then�[0m
�[36;1m echo "::error::GitHub API returned HTTP $status for tag $CONTRACT_TAG."�[0m
🧰 Additional context used
📓 Path-based instructions (5)
**/*
📄 CodeRabbit inference engine (CLAUDE.md)
**/*: Use Serena's semantic, symbol-aware tools as the primary tools for reading and editing code; use built-in Read, Glob, Grep, and Edit only under the stated exceptions.
Before editing a code file, inspect its symbol overview, read the specific symbols being changed, and edit them with Serena's symbol-aware tools.
Understand the existing code before changing it and make the smallest change that satisfies the request; avoid unrelated cleanup, premature abstractions, unnecessary error handling, feature flags, and compatibility shims.
Prefer editing existing files over creating new ones, and never create Markdown or README files unless explicitly requested.
For exploratory questions, provide a 2–3 sentence recommendation with the main tradeoff and do not implement until the user agrees.
For UI or frontend changes that cannot be tested in a browser, explicitly state that browser testing was not performed rather than claiming success.
Address security issues when discovered, including injection, XSS, SQL injection, path traversal, and secret leaks.
Pause and obtain confirmation before destructive, hard-to-reverse, externally visible, or third-party-upload actions, including deleting files or branches, dropping tables, force-pushing, modifying CI/CD, posting externally, or uploading content.
When blocked, investigate the root cause instead of bypassing it with --no-verify, --force, or deletion; investigate unfamiliar files, branches, and configuration before deleting them.
Only commit when explicitly asked; do not proactively update git configuration or push changes.
Do not skip Git hooks unless explicitly asked; if a pre-commit hook fails, fix the issue, re-stage, and create a new commit rather than amending.
Stage files by name rather than using git add -A or git add ., to avoid accidentally including secrets or large binaries.
Use a HEREDOC for commit messages, and add co-author attribution only when the user explicitly requests the exact trailer.
Do not force-pus...
Files:
docs/plans/consolidated-multi-repo-roadmap.mddocs/plans/handoff-promote-0114-plugins.md
!**/.env,!**/credentials.json,!**/*.pem
📄 CodeRabbit inference engine (CLAUDE.md)
Do not commit files that appear to contain secrets, including .env, credentials.json, and PEM files; warn before doing so even if explicitly requested.
Files:
docs/plans/consolidated-multi-repo-roadmap.mddocs/plans/handoff-promote-0114-plugins.md
**/*.{rs,md}
📄 CodeRabbit inference engine (CONTRIBUTING.md)
Match existing naming, module layout, and documentation level in the file being edited; update
AGENTS.md,docs/, or command help when structure, conventions, or user-visible behavior changes.Tests must cover failure modes, not only successful execution.
Files:
docs/plans/consolidated-multi-repo-roadmap.mddocs/plans/handoff-promote-0114-plugins.md
**/*.{rs,md,toml}
📄 CodeRabbit inference engine (CONTRIBUTING.md)
Use the repository's established serialization and module conventions rather than introducing unrelated refactors.
Files:
docs/plans/consolidated-multi-repo-roadmap.mddocs/plans/handoff-promote-0114-plugins.md
**/*.md
📄 CodeRabbit inference engine (REVIEW.md)
Update documentation and
AGENTS.mdwhen project structure or conventions change.
Files:
docs/plans/consolidated-multi-repo-roadmap.mddocs/plans/handoff-promote-0114-plugins.md
🔍 Remote MCP GitHub Copilot
Relevant review context
- PR
#85is documentation-only: two files changed (+20/-7). The related registry intake PR#45is merged and records the same five plugins, Nu>=0.114.0 <0.115.0, verified with Nu 0.114.1, across four targets with Intel macOS excluded. - The required Roadmap drift check is failing. CI compares the local consolidated roadmap against the frozen contract SHA and explicitly requires a coordinated
scripts/bump-contract.shupdate when the roadmap changes., - Other listed CI checks—including Linux, Windows, and macOS tests, formatting, Clippy, packaging, and acceptance checks—succeeded.
- The companion
numan-plugins#42bookkeeping PR is still open; its stated purpose is to mark the five pluginsPROMOTED, clear pending-registry metadata, and record Wave 2 completion. The currentnuman-pluginsmasterstill shows those entries asELIGIBLEwith pending-registry notes., - The handoff checklist’s final item is now checked in the PR head, after an automated fix.,
consolidated-multi-repo-roadmap.md must match CONTRACT_SHA; keep wave2 completion notes in the handoff and numan-plugins roadmap. Co-authored-by: Anthony Thompson <github@trackdub.com>
Avoid directing agents to edit the consolidated multi-repo roadmap without a coordinated CONTRACT_SHA bump. Co-authored-by: Anthony Thompson <github@trackdub.com>
Mark Windows lifecycle-prove done with completion rule and run link; state backlog/roadmap criterion as satisfied via plugins#42 plus this handoff. Co-authored-by: Anthony Thompson <github@trackdub.com>
|
@coderabbitai review |
|
2 participants
Summary
Bookkeeping for wave2 after numan-registry#45 production publish.
Companion: numan-plugins backlog/manifest PROMOTED PR.