Skip to content

Upgrade nufmt dependencies / toolchain #214

Description

@Sha1rholder

nufmt has fallen behind the main Nushell repository, and some of its dependencies are now deprecated.

Sooner or later it'll have to:

  • migrate to Rust Edition 2024
  • update dependencies to match the main Nushell repository
  • remove and replace deprecated components

Given the version gap, preserving compatibility with the current dependency set probably isn't worth the additional complexity.

I have roughly implemented the updates and would be happy to open a PR if this approach seems reasonable. LLMs should be very suitable to help with this job. I promise that I will carefully review the code line by line. But since the current nufmt itself still “eats code” (nushell/nushell#18558), I think it's not very meaningful to keep the upgraded nufmt behavior exactly the same as before. But I'll try to maintain consistency with the original design goals and will make it passes all the tests.

I expect the workload won't be too large, but it will almost definitely generate A LOT OF diff. I'll also use .gitattributes to help minimize some of them.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions