refactor(painter): read skip_buffer_lines through its own range - #1217
Open
kronberger-droid wants to merge 1 commit into
Open
kronberger-droid wants to merge 1 commit into
kronberger-droid wants to merge 1 commit into
Conversation
kronberger-droid
marked this pull request as ready for review
September 16, 2026 12:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
skip_buffer_linesandskip_buffer_lines_rangewere copy-paste twins, differing only in whether the result gets sliced and trimmed.skip_buffer_linesnow takes its bounds fromskip_buffer_lines_range, so the line skipping exists once and the two cannot drift.No behavior change, both are private to the painter.