Skip to content

feat: add tpl support for sessionStorage.redis.existingSecret #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pierluigilenoci wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: add tpl support for sessionStorage.redis.existingSecret #414

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dcca9b8
feat: add tpl support for sessionStorage.redis.existingSecret
pierluigilenoci Jun 9, 2026
76bb562
fix(ci): provision redis secret via extraObjects in tpl test
pierluigilenoci Jun 9, 2026
d93617b
fix(ci): remove redis-existingsecret-tpl CI test
pierluigilenoci Jun 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions helm/oauth2-proxy/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: oauth2-proxy
version: 10.7.0
version: 10.8.0
apiVersion: v2
appVersion: 7.15.3
home: https://oauth2-proxy.github.io/oauth2-proxy/
Expand Down Expand Up @@ -31,12 +31,7 @@ kubeVersion: ">=1.16.0-0"
annotations:
artifacthub.io/changes: |
- kind: added
description: Add alpha-config.source and alpha-config.name helpers for centralized alpha config resolution
description: Add tpl support for sessionStorage.redis.existingSecret to allow dynamic secret names when used as subchart
links:
- name: GitHub PR
url: https://github.com/oauth2-proxy/manifests/pull/405
- kind: added
description: Add deprecation guards for invalid alphaConfig combinations
links:
- name: GitHub PR
url: https://github.com/oauth2-proxy/manifests/pull/405
- name: GitHub Issue
url: https://github.com/oauth2-proxy/manifests/issues/409
4 changes: 2 additions & 2 deletions helm/oauth2-proxy/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ spec:
valueFrom:
secretKeyRef:
{{- if .Values.sessionStorage.redis.existingSecret }}
name: {{ .Values.sessionStorage.redis.existingSecret }}
name: {{ tpl .Values.sessionStorage.redis.existingSecret $ }}
{{- else if .Values.sessionStorage.redis.password }}
name: {{ template "oauth2-proxy.fullname" . }}-redis-access
{{- else }}
Expand Down Expand Up @@ -245,7 +245,7 @@ spec:
valueFrom:
secretKeyRef:
{{- if or .Values.sessionStorage.redis.sentinel.existingSecret .Values.sessionStorage.redis.existingSecret }}
name: {{ .Values.sessionStorage.redis.sentinel.existingSecret | default .Values.sessionStorage.redis.existingSecret }}
name: {{ tpl (.Values.sessionStorage.redis.sentinel.existingSecret | default .Values.sessionStorage.redis.existingSecret) $ }}
{{- else }}
name: {{ template "oauth2-proxy.fullname" . }}-redis-access
{{- end }}
Expand Down
1 change: 1 addition & 0 deletions helm/oauth2-proxy/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -604,6 +604,7 @@ sessionStorage:
type: cookie
redis:
# Name of the Kubernetes secret containing the redis & redis sentinel password values (see also `sessionStorage.redis.passwordKey`)
# Supports Helm templating, e.g. '{{ .Release.Name }}-redis' or '{{ include "myapp.redis.secretName" . }}'
existingSecret: ""
Comment on lines 606 to 608
# Redis password value. Applicable for all Redis configurations. Taken from redis subchart secret if not set. `sessionStorage.redis.existingSecret` takes precedence
password: ""
Expand Down
Loading