omarchy toggle bar on hides the bar instead of showing it #13846

Summary

omarchy toggle bar on produces the opposite of what the command name says.
Running it hides the menu bar; omarchy toggle bar off shows it.

Steps to reproduce

omarchy toggle bar on
hyprctl layers | grep omarchy-bar

Actual

The omarchy-bar layer is still mapped, but parked above the top edge of the
screen:

Layer 59654db57d60: xywh: 0 -26 1920 26, a: 1, namespace: omarchy-bar
                                                          ^^^ negative Y

Expected

omarchy toggle bar on should leave the bar visible at 0 0.

Cause

/usr/share/omarchy/bin/omarchy-toggle-bar forwards its argument unchanged:

omarchy-toggle bar-off "${1:-toggle}"

and omarchy-toggle implements on as "create the flag file":

enable() {
  mkdir -p "$(dirname "$FLAG")"
  touch "$FLAG"
}

Meanwhile the bar treats the presence of that flag as "hidden"
(/usr/share/omarchy/shell/plugins/bar/Bar.qml:1171):

command: ["bash", "-c", "[[ -f $HOME/.local/state/omarchy/toggles/bar-off ]] && echo yes || echo no"]

So the flag name already encodes the inverted sense — bar-off — and the
generic on/off actions then apply it the wrong way round:

Impact

The documented way to bring the bar back is inverted. A user who runs
omarchy toggle bar on to recover a missing bar gets no visible change, and
omarchy toggle bar then appears to be a no-op. The desktop looks broken with
no obvious way back except reading Bar.qml to find the flag name.

Notes

omarchy-toggle is generic, so it cannot be fixed by swapping on and off
there — that would invert every other toggle (idle-lock, notifications,
crash-capture, screensaver, nightlight, battery-percentage,
workspace-layout, window-gaps, one-window-ratio). Every other consumer
already treats a present flag as "feature on", so bar-off looks like the
odd one out.

Suggested direction, whichever is chosen:

1. Rename the flag to bar-hidden and have omarchy-toggle-bar map
   on -> remove, off -> create. Keeps omarchy-toggle generic.
2. Or keep bar-off and translate inside omarchy-toggle-bar.

Option 1 also matches the comment already in Bar.qml:38.

Migration concern for option 1: an existing toggles/bar-off file would be
ignored, so the bar would pop back into view once on upgrade. Probably fine,
but worth a note.

Environment

• Omarchy 4.0.4-1
• Host Legend