Render usageStatusText in the agents status banner

[Bartok9]

Summary

The agents panel status banner is visible when usageStatusText is non-empty, but the Text node rendered authHelpText. A collector that sets status without auth help therefore draws an empty urgent-styled box.

This makes the banner text follow the same field as its visibility gate (usageStatusText, falling back to authHelpText).

Fixes #10000

Test plan

• Reproduce with the example collector JSON from Agents panel: status banner is gated on usageStatusText but renders authHelpText, producing an empty warning box #10000 (usageStatusText set, authHelpText empty): empty red box before, status line after.
• Confirm existing claude/codex/fireworks banners still show when they set authHelpText together with status.
• Visual change is one line of status copy in the agents panel; no layout/theme change.

[omarchybot]

Thanks for this. The bug is real, and it is still on quattro. Another open pull request, #8497, fixes the same bug, issue #8445, and it is the fix that should carry it, so I have not taken this one further.

What I checked. quattro has since rewritten the agents panel, and the status card this diff edits is gone, which is why the branch no longer merges. The bug moved into the card's replacement: the single-account trouble line at shell/plugins/agents/Panel.qml:1332-1341 shows when usageStatusText holds a non-sign-in status, but it still draws authHelpText. #8497 already carries its fallback onto that line, with a test assertion in test/shell.d/agents-panel-test.sh. A worker has reproduced it there: the line is empty on quattro, and it shows the status with the fix.

Why that one rather than this. The two use the opposite fallback order. Every in-tree collector that sets a non-sign-in status also sets a more specific help line: "Codex unavailable" comes with "codex not found in PATH", and "Codex limits unavailable" and "Claude limits unavailable" come with the actual error. With usageStatusText || authHelpText, the panel would show the generic status and hide that detail. With authHelpText || usageStatusText, those tabs render as they do today, and a third-party record with a status and no help still gets its status shown, which was the point of #10000 and #8445. #10000 was closed as a duplicate of #8445.

Second opinion. Codex Medium was asked to compare the two from the code alone, without my answer. It picked #8497 for the same reason; its independence is not guaranteed. It also noted something neither pull request changes: when Grok reports "Grok limits unavailable", it keeps its default sign-in help, so the help-first order shows sign-in advice there. That is a collector issue for a separate fix.

Nothing was run on a worker for this branch, since it no longer applies to quattro. Whether to close it in favour of #8497 is the maintainer's call.

[Bartok9]

Agreed — #8497 should carry this.

The status card this branch edits is gone on quattro, so rebasing would just chase a rewrite. Help-first (authHelpText || usageStatusText) is the right order for in-tree collectors that already attach a more specific help line; status-first would hide that detail. Happy to close this in favour of #8497 whenever you want it off the queue — leaving that call with you, as noted.

[dhh]

Thanks! The same fix is coming in through #14049 (from #8497). Closing in favor of that.

[Bartok9]

Thanks — closing in favor of #14049 works for me. Glad the fix is landing.