You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Security] Stage menu IPC files out of world-writable /tmp - #10506
Real issue — keep this open. Closing it in favor of the other /tmp PRs would leave the menu IPC hole open; nothing else relocates omarchy-menu-select / -input / -images.
Please harden the fallback before we merge, though. ${XDG_RUNTIME_DIR:-/tmp/omarchy-$UID} + mkdir -m 700 -p does not fix an existing attacker-owned /tmp/omarchy-$UID (mkdir -p won't chmod/chown what's already there). Match the stronger pattern in #11600 / #9084: prefer a real non-symlink XDG_RUNTIME_DIR, otherwise a private state/cache dir under $HOME — not a predictable path in world-writable /tmp.
Also worth covering in tests: the unset-XDG_RUNTIME_DIR fallback, and a live stub run for omarchy-menu-images (not only the static grep).
csfh
added
the
verified
Omarchy Triage has verified that this issue is ready for final review
label
Sep 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
verifiedOmarchy Triage has verified that this issue is ready for final review
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
omarchy-menu-select,omarchy-menu-input, andomarchy-menu-imagesused baremktempfor selection/done files/tmp; afterrmof the done file, another user can recreate that name$XDG_RUNTIME_DIR(or a 0700/tmp/omarchy-$UIDfallback)Test plan
bash test/shell.d/menu-ipc-path-test.shomarchy menu inputand confirm the IPC files are not created under/tmp/tmp.*