Repository navigation
Conversation
paulogeyer
left a comment
There was a problem hiding this comment.
+1 — right fix for #12085.
Live-verified on Omarchy / Hyprland 0.56.2: stock SUPER+ALT+3 (group of 2) shows Runtime error in lua: Index out of range; with a size-guard before hl.dsp.group.active the miss is a silent no-op and SUPER+ALT+1/2 still switch.
Please also pull in the small regression test from #8411 (test/shell.d/hyprland-group-bindings-test.sh) so this doesn’t regress. Prefer this focused PR over the pcall-only hunk in #12155.
|
Thanks for this, @aastrand. It is the same change as #8411, which was opened earlier against Both PRs fix #12085 the same way: in I compared the two diffs by reading them. Nothing was run for this check. Codex Medium was asked separately whether they make the same change and agreed. Independence isn't guaranteed, since it can read this session's reasoning. If I've got this wrong and there is a difference that matters, say so and it can be reopened. |
What changed
Guard the numbered group-window bindings before dispatching to
hl.dsp.group.active.Pressing Super+Alt+1–5 now:
This prevents Hyprland from showing a Lua runtime-error notification for a missing group member.
Screenshot pre-fix
Testing
luac -p default/hypr/bindings/tiling.luabash test/shell.d/hyprland-default-config-test.shbash test/shell.d/hyprland-binding-conflicts-test.sh