Repository navigation
Share one sysfs T2 helper for packages and arch-mact2 - #10808
Closed
Chessing234 wants to merge 3 commits into
Closed
Chessing234 wants to merge 3 commits into
Chessing234 wants to merge 3 commits into
Conversation
The old lspci | grep -q path SIGPIPE'd on a long device list and looked like "no T2" under pipefail.
Both install scripts asked lspci the same question.
1 task done
Contributor
Author
|
folded into #12076 — same sysfs hardware detect work, easier as one review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix-t2.shandhardware/pacman.shboth greppedlspci -nnfor Apple 106b:1801/1802.omarchy-hw-t2reads sysfs likeomarchy-hw-nvidia, so we do not SIGPIPE a chatty lspci under pipefail (the Follow up to #6559 - update fix-t2.sh and migrations/1785944594.sh to not use grep -q #6608 class of bug).Test plan
test/shell.d/hw-t2-test.sh