Repository navigation
Stop update stay-awake from hanging on sudo -v - #12900
Chessing234 wants to merge 1 commit into
Conversation
Bare sudo -v hangs under passwordless NOPASSWD (verifypw=all) and under omarchy-update's logging PTY; fall back to pkexec only when attended.
|
Verified: At
The new sudo regression test passes on head and fails against the unfixed baseline. The unattended fallback still attempts inhibition as the user; it does not skip the command entirely. Optional test improvement: Add an early sudo stub in Review informationTest scope: Pinned source inspection, targeted shell tests, baseline controls, and mocked authorization/backend routing. Real sudo authentication, polkit dialogs, privileged inhibitor cleanup and sleep prevention were not validated. Community review: Independent automated community review, unaffiliated with the Omarchy team, intended to help prepare PRs for their review. Automated AI review: Astra initial inspection, independent Opus 5 and Astra technical reviews, followed by synthesis and verification against targeted evidence. |
|
folding into #12109 — sudo -n stay-awake probe is on the /tmp staging fold now. |
Summary
omarchy-update-stay-awakeno longer gates on baresudo -v, which hangs under passwordlessNOPASSWD(verifypw=all) and underomarchy-update's logging PTY (Fixes #9066).sudo -n true; use sudo when that works, pkexec when attended without a ticket, and skip privileged inhibit whenOMARCHY_UPDATE_UNATTENDED=1.Test plan
bash test/shell.d/update-stay-awake-sudo-test.shomarchy sudo passwordlessthenomarchy update -ycompletes without a password hangMade with Cursor