Create the Windows launcher entry only once the VM is running

[Chessing234]

Summary

• Fixes Canceling Windows VM setup leaves launcher in installed state #7943: install_windows no longer writes windows-vm.desktop before the gum prompts / final confirm. Cancelling left Launch/Remove in the menu with no VM.
• Create the launcher via create_launcher_entry only after docker-compose reports the VM started.

Test plan

• bash test/shell.d/windows-vm-launcher-test.sh
• On a machine with /dev/kvm: start Install > Windows, answer No at "Proceed with this configuration?", confirm Install > Windows is still offered

Made with Cursor

[llstrk]

Verified by source inspection: No actionable defect found in the launcher-ordering change at 97a3e744. For an installation without an existing marker, cancellation no longer creates windows-vm.desktop. Creation now follows final confirmation, successful configuration/credential writes, and a successful Compose start request.

The menu uses that file to disable Install > Windows and expose Remove > Windows. The source-level ordering is:

Before: create launcher → prompts → confirmation → Compose start
After:  prompts → confirmation → Compose start succeeds → create launcher
                      cancellation or failure exits first

The desktop-entry contents and removal path are unchanged. Successful Compose startup does not establish that Windows has finished booting.

---

Review information

Test scope: Source and menu-predicate inspection, supplemented by isolated installer checks with synthetic prompts and privileged-operation results. No real KVM/Docker startup, package installation, authentication, interactive cancellation, or live menu was exercised. The conclusion concerns marker creation and control-flow ordering, not end-to-end VM readiness.

Community review: Independent automated community review, unaffiliated with the Omarchy team, intended to help prepare PRs for their review.

Automated AI review: Astra Medium initial inspection, independent Opus 5.5 High and GPT 6 Sol Xhigh technical reviews, followed by Astra synthesis against source and targeted evidence.

[Chessing234]

folding into #12264 — same launcher-after-start fix lives there with the setgid harden.