Repository navigation
Conversation
|
No important actionable issue found in the inspected scope at Verified by source inspection: both account RPCs now receive the same eight-second budget as initialization, and the descriptive exception reaches the panel through
These are per-call budgets, not an eight-second total deadline. The inspected updater and panel impose no shorter timeout that would override them. Review informationTest scope: Source review of the collector, added tests, updater and panel integration. No runtime result is relied on here; the repository test suite, live panel and authenticated Codex behavior under load were not validated. Whether eight seconds is sufficient under real load remains unmeasured. Community review: Independent automated community review, unaffiliated with the Omarchy team, intended to help prepare PRs for their review. Automated AI review: Astra Medium initial inspection and synthesis, independent Opus 5.5 High and GPT 6 Sol Xhigh technical reviews, with claims checked against the pinned source. |
|
Tested in the Omarchy VM (Omarchy 4.0.4): The clearer However, testing the 8s timeout under real/simulated Codex stdout traffic revealed that increasing the timeout budget does not resolve the root timeout: Issue observed in VMWhen Codex sends notifications or messages batched in stdout chunks (common during startup or under load), Python's In testing:
Suggested fixThe timeout is primarily caused by this I/O buffer stall rather than Codex taking >4s to respond. PR #12979 addresses this root cause by switching to unbuffered binary reads ( |
3996942 to
c737c49
Compare
|
Withdrawn in favor of #12979. Runtime testing showed that increasing the Codex RPC timeout from 4s to 8s does not fix the failure; it only makes the same buffered-I/O stall take longer. #12979 addresses the reproduced root cause by draining buffered stdout before waiting on the file descriptor. I reset this branch to current "quattro". The clearer timeout diagnostic from this PR may still be useful as a small follow-up after the I/O fix lands, but it should not compete with the root-cause patch. |
What
Raise
account/readandaccount/rateLimits/readRPC timeouts from 4s to 8s (same budget asinitialize).When
rpc_requesttimes out, raiseTimeoutErrorwithCodex RPC timed out waiting for {method}instead of the bare method name.Why
Under load the Codex app-server often needs more than 4s for
account/rateLimits/read. The collector storedstr(TimeoutError)asauthHelpText, so the panel showedaccount/rateLimits/readand looked like an auth/unavailable failure (#12880).Tests
All assertions passed, including source pins for the 8s timeouts / clear TimeoutError text and a short-timeout unit check that the message names the method and says timed out.
Pinned tip:
d3cfd53b997f8bdcf776b8db68bf0d735e7a065dFixes #12880