Skip to content

Skip placeholder and FALLBACK screens when building bars - #13645

Closed
AnPod wants to merge 1 commit into
omacom:quattrofrom
AnPod:cursor/fix-idle-panels-e0d3
Closed

AnPod wants to merge 1 commit into
omacom:quattrofrom
AnPod:cursor/fix-idle-panels-e0d3

Conversation

@AnPod

@AnPod AnPod commented Sep 28, 2026

Copy link
Copy Markdown

Summary

Fixes #13072

Idle wake recreated panels / duplicate IpcHandlers because Qt’s nameless placeholder and Hyprland FALLBACK spawned bars.

Change

  • Bar Variants use BarModel.realScreens() so placeholder/FALLBACK screens do not get bars

Test plan

  • bash test/shell.d/bar-test.sh

@llstrk

llstrk commented Sep 29, 2026

Copy link
Copy Markdown

Automated duplicate check

Community review: Independent automated community review, unaffiliated with the Omarchy team, intended to help prepare PRs for their review.

Possible duplicate: the 46 lines this PR adds are the same as in #13477, an open PR by the same author from 2026-09-27. Because of that, this PR was not reviewed separately. Closing one of the two would leave maintainers a single PR to review.


Opt out: To stop receiving these reviews, reply to this comment saying so.

Co-authored-by: AnPod <AnPod@users.noreply.github.com>
@cursor
cursor Bot force-pushed the cursor/fix-idle-panels-e0d3 branch from 8ae1446 to 00ef70c Compare September 29, 2026 21:12
@omarchybot omarchybot added the bug Something isn't working label Oct 1, 2026
@omarchybot

Copy link
Copy Markdown
Collaborator

Closing this as a duplicate of #13165, which was opened on 24 September against quattro and makes the same change.

Comparing the two diffs line by line: Bar.qml is identical, with all three Variants switched to root.realScreens; isRealScreen and realScreens in BarModel.js are identical apart from the comment above them; and the bar-test.sh assertions are the same, apart from blank lines. The one code difference favours #13165: its check that all three Variants use the filter defaults the rg -c count to 0, while the one here becomes (( != 3 )) when nothing matches, which is an arithmetic error that lets the test pass.

What this pull request adds is the link to #13072. Whether #13165 should also close that issue is for the maintainer to decide there; the bar change only partly addresses #13072, since the background and notification windows are still created for the placeholder screen.

Compared by Claude Opus 5.5; Codex Medium was asked separately, from the two diffs alone, and agreed they are the same change (independence is not guaranteed). Nothing was run for this, because closing a duplicate needs only the comparison. If this is wrong, reopen it.

@omarchybot omarchybot added the duplicate This issue or pull request already exists label Oct 3, 2026
@omarchybot omarchybot closed this Oct 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working duplicate This issue or pull request already exists

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Idle wake recreates shell panel components without destroying the old ones (duplicate IpcHandlers, leaked child processes)

4 participants