Repository navigation
Conversation
This was referenced Sep 29, 2026
An outer sudo made mise/AUR steps write root-owned user state. Privileged steps already escalate on their own. Co-authored-by: AnPod <AnPod@users.noreply.github.com>
cursor
Bot
force-pushed
the
cursor/fix-update-refuse-root-ef3e
branch
from
September 29, 2026 21:13
b9c4cb1 to
6ed8c45
Compare
|
Thanks for this. #11479 from @yashranaway fixes the same thing (it rejects root-run updates before any user state changes) and is a couple of weeks older. On 2026-10-03 the maintainers closed #13377, an equivalent fix, in favor of #11479 so the credit stays with the first fix. This one will probably go the same way. If #11479 misses a case you've hit, adding it there would be the best route. (Small note if it does continue: the test only greps the source for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes omacom/omarchy#13329:
sudo omarchy updatemademise/ user steps write root-owned state under~.Changes
EUID == 0-ycannot skip itTest plan
./test/shell.d/update-refuse-root-test.sh