Repository navigation
Fix Codex limits collector approval policy - #7751
Closed
purple-monkey-dishwasher wants to merge 1 commit into
Closed
purple-monkey-dishwasher wants to merge 1 commit into
purple-monkey-dishwasher wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Codex usage collector for current Codex CLI approval-policy support.
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
Changes:
- Replaces the removed
untrustedpolicy with non-interactivenever. - Adds regression coverage for the exact app-server arguments.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
bin/omarchy-agent-usage-codex |
Uses the supported Codex approval policy. |
test/shell.d/agent-usage-codex-scanner-test.sh |
Verifies collector launch arguments. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Dupe of #7649 |
This was referenced Aug 23, 2026
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codex limits unavailable because collector uses removed
untrustedapproval policyWhat happened
On Omarchy 4.0.0-1 with Codex CLI 0.149.0, the Agents toolbar panel shows
Codex limits unavailableand a redinitializeerror even thoughcodex login statusreportsLogged in using ChatGPT.The panel still shows historical local usage, but the plan and rate-limit windows are absent.
Root cause
bin/omarchy-agent-usage-codexlaunches the app server with:Codex CLI 0.149.0 rejects
untrusted:Because stderr is discarded, the collector waits for the
initializeRPC until it times out. It then exposes the exception method name asauthHelpText, producing the misleading redinitializemessage.Expected behavior
The collector should start the current Codex app server non-interactively and return the authenticated account's plan and rate-limit windows.
Proposed fix
Replace
-a untrustedwith-a neverand add a regression assertion covering the exact app-server launch arguments.With this change, the collector returned the authenticated plan and a populated 7-day limit window on the affected machine, with an empty
usageStatusText.Reproduction
codex login.omarchy agent usage-update --force codex.Verification
bash test/shell.d/agent-usage-codex-scanner-test.shpasses.git diff --checkpasses../test/shellsuite reaches the changed test successfully; four unrelated environment/checkout-dependent tests fail because the separateomarchy-pkgscheckout is unavailable (plus its dependent coverage checks).